Puppeteer should only enable CDP or WebDriver BiDi depending on the protocol in use
Categories
(Remote Protocol :: Agent, defect, P2)
Tracking
(firefox125 fixed)
| Tracking | Status | |
|---|---|---|
| firefox125 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m10])
Currently Puppeteer uses the default settings in Firefox for the CDP and WebDriver BiDi protocols which means that both are actually enabled.
Instead Puppeteer should set remote.active-protocols to 2 if CDP is used and to 1 when BiDi is used. This can be done in the launcher specific code for each protocol.
By doing that we can be sure that no CDP specific recommended preferences are actually affecting the WebDriver BiDi usage.
A fix here would also require an upstream change.
|
Assignee | |
Comment 1•9 months ago
|
||
We should actually fix this upstream first and wait for a Puppeteer release before doing any changes on our side. I'll try to get to it soonish.
|
|
Assignee | |
Comment 2•9 months ago
|
||
I've created an upstream PR: https://github.com/puppeteer/puppeteer/pull/12014
|
|
Assignee | |
Comment 3•9 months ago
|
||
(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #2)
I've created an upstream PR: https://github.com/puppeteer/puppeteer/pull/12014
The upstream PR got merged. Now lets wait for the next release.
|
|
Assignee | |
Updated•9 months ago
|
|
|
Assignee | |
Comment 4•9 months ago
|
||
This change actually caused a regression which is handled by bug 1882748. The fix is already on autoland, and once it reaches mozilla-central and a new Nightly build has been created the Puppeteer folks will release a new version.
That means I'll not port the patch to get it landed on mozilla-central, but directly will vendor in the new Puppeteer release via bug 1878632.
As such lets close this bug as fixed.
|
|
Assignee | |
Updated•9 months ago
|
Description
•