1882260 - Add support for "contexts" argument to "network.addIntercept" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The network.addIntercept command should support the context argument so that intercepts can be set to specific top-level browsing contexts only.

This feature got recently added via https://github.com/w3c/webdriver-bidi/pull/653/.

Tests are written upstream and will be synced via bug 1881005.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

After talking to Puppeteer folks this is actually a missing feature that is highly wanted. If more than one open tab is used users will face issues. For details see https://github.com/puppeteer/puppeteer/pull/12106.

Julian, do you think that you could prioritize this bug? I think that we can move others over to M11.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1882260 - [bidi] Add support for contexts argument to network.addIntercept command

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1882260 - [wdspec] Add test for addIntercept contexts argument with frames

Depends on D205459

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ab10edbb899
[bidi] Add support for contexts argument to network.addIntercept command r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/6794b17b50ec
[wdspec] Add test for addIntercept contexts argument with frames r=webdriver-reviewers,Sasha

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45309 for changes under testing/web-platform/tests

Comment 6

[pstanciu]

Backed out for causing failures on contexts.py

• Backout link
• Push with failures
  tier 1 failure was noticed here:
• Failure Log

Comment 7

[Julian Descottes [:jdescottes]]

It seems that on asan builds the requests take too long to be aborted and result in a test timeout.

Comment 8

[Julian Descottes [:jdescottes]]

I will change the tests to assert the network events instead of waiting for the timeouts, this should be much faster on all platforms.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bbb76c68bf8
[bidi] Add support for contexts argument to network.addIntercept command r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/e02aed8fb198
[wdspec] Add test for addIntercept contexts argument with frames r=webdriver-reviewers,Sasha

Comment 10

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5bbb76c68bf8
https://hg.mozilla.org/mozilla-central/rev/e02aed8fb198

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot