1882503 - [DE][tennis-point.de] Form autofill/preview/clear aren't applied on all the eligible fields

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P3)

Description

[Hani Yacoub, Desktop QA]

Attachment: Screen Recording 2024-02-28 at 14.32.26.mov

Found in

• Firefox Nightly 125.0a1

Affected versions

• Firefox Nightly 125.0a1

Tested platforms

• Affected platforms: macOS 11.6

Preconditions

• Install DE Firefox build
• Use DE VPN
• browser.search.region = DE
• extensions.formautofill.addresses.experiments.enabled - true
• extensions.formautofill.addresses.supportedCountries = DE
• extensions.formautofill.addresses.capture.requiredFields = empty

Steps to reproduce

1. Reach the address form on https://www.tennis-point.de
2. Click on "Name" field
3. Select any of the options for the dropdown
4. Right click on any of the fields and choose "Clear autofill form"
5. Repeat steps from above for the rest of the fields

Expected result

• Form autofill/preview/clear should be applied on eligible fields.

Actual result

• Form autofill/preview/clear are only applied on the selected field.

Regression range

• N/A

Additional notes

• Not reproducible on Chrome.

Comment 1

[Hani Yacoub, Desktop QA]

Attachment: tennispointde.html

Comment 2

[Neil Deakin]

The field 'zus info' is being detected as an address-line1 type field which already exists earlier in the form so it and the remaining fields are incorrectly split into a separate section. Removing the 'zus info' field beforehand makes this form work correctly.

Comment 3

[Neil Deakin]

The 'Zus Info' should actually be treated as an address-line2 field, not a repeated address-line1.

Comment 4

[Neil Deakin]

Attachment: Bug 1882503, allow certain fields to appear between the address line fields, r=#credential-management-reviewers

On some sites, such as german sites the extra address info can appear after the city, postal code and other fields. This change allow certain fields to appear in-between the address fields, but other types of fields such as name and email should not. The changes to browser_autocomplete_off_on*.js and browser_basic.js are now treated as valid, and the change to browser_HomeDepot.js is because the second address field has autocomplete='billing street-address' so should be treated as a street address despite the ui suggesting it should be a city/state

Comment 5

[Dimi Lee [:dimi]]

(In reply to Neil Deakin from comment #3)

The 'Zus Info' should actually be treated as an address-line2 field, not a repeated address-line1.

Is it possible to fix this issue by inferring the right type (address-line2) in the first place?

Comment 6

[Neil Deakin]

Is it possible to fix this issue by inferring the right type (address-line2) in the first place?

This comment is out of date. The address-line2 is being identified correctly, but is being modified to an address-line1 because the postal code and city fields appear in-between.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/446869ac6007
allow certain fields to appear between the address line fields, r=credential-management-reviewers,dimi

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/446869ac6007