1882779 - [Linux] Avoid compositor pause and make it thread safe

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

• We should avoid compositor pause but rather render to offscreen surface after XWindow hide.
• We need to make compositor/nsWindow calls thread safe

Comment 1

[Martin Stránský [:stransky] (ni? me)]

We need a bit rework how we manage popup close and sync compositor shutdown for it.
Beta will go with hotfix in Bug 1882021 where we force-update XWindow after popup open.
Nightly is partially covered by Bug 1882462 (destroy layer manager on popup close).

To correctly fix it we should update GtkCompositorWidget to be thread safe, fix rendering offscreen to EGLWindow and make sure XWindow is updated by GtkCompositorWidget::EnableRendering() wihout previous GtkCompositorWidget::DisableRendering() call.

We should not use GtkCompositorWidget::DisableRendering() to hold rendering to invalid XWindow as it leads to UI freezes/timeouts.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Always create offscreen rendering surface if we're missing native rendering window r?lsalzman

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] remove disable rendering, remove map/unmap handlers r?emilio

• Merge nsWindow::DisableRendering() and nsWindow::OnUnmap() as it handles the same event (widget unmap)
• Remove nsWindow map/unmap mContainer handlers and call them directly from mContainer. It ensures correct order
  where we stop rendering / clear resources and then release them.

Depends on D204066

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Simplify OnUnmap handler r?emilio

• Clean up native rendering resources stored at GtkCompositorWidget and mSurfaceProvider
• Call SendResume() to all rendering backends, it leads to nullptr result from nsWindow::GetNativeData(NS_NATIVE_EGL_WINDOW) from compositor
  thread (as nsWindow is unmapped) and rendering backend will create offscreen rendering buffer then.

Depends on D204067

Comment 7

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Remove nsWindow destroy mutex r?emilio

• Rename mDestroyMutex to mWindowVisibilityMutex to make clear it protects window visibility changes
• Make mIsMapped atomic - we want to read it from rendering thread. We don't protect nsWindow::IsMapped() getter by mutex
  as we know backend code can render to hidden window safely.

Depends on D204068

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Rename CompositorWidgetChild::DisableRendering() to CompositorWidgetChild::CleanupResources() and CompositorWidgetChild::EnableRendering() to CompositorWidgetChild::SetRenderingSurface() r?emilio

Depends on D204069

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Don't suspend rendering to hidden widget as backend code can handle it r?emilio

Depends on D204071

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Lock WindowSurfaceProvider between StartRemoteDrawingInRegion() and EndRemoteDrawingInRegion() calls r?emilio

It makes sure underlying native surface (XWindow/wl_surface) stays allocated until compositor thread finishes rendering and returns
drawing target to us.

Depends on D204072

Comment 11

[Intermittent Failures Robot]

19 failures in 659 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19

Platform and build breakdown:

• linux1804-64-qr: 19
  • debug: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-08&endday=2024-03-08&tree=all

Comment 12

[Intermittent Failures Robot]

86 failures in 4198 pushes (0.02 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 76
• mozilla-central: 7
• try: 3

Platform and build breakdown:

• linux1804-64-qr: 86
  • debug: 86

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-04&endday=2024-03-10&tree=all

Comment 13

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7b5a47bf60137ced5cf807345f009ea36cbf397

Comment 14

[Intermittent Failures Robot]

16 failures in 813 pushes (0.02 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• autoland: 15
• try: 1

Platform and build breakdown:

• linux1804-64-qr: 16
  • debug: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-13&endday=2024-03-13&tree=all

Comment 15

[Intermittent Failures Robot]

61 failures in 3849 pushes (0.016 failures/push) were associated with this bug in the last 7 days.

This is the #8 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 53
• try: 4
• mozilla-central: 4

Platform and build breakdown:

• linux1804-64-qr: 61
  • debug: 61

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-11&endday=2024-03-17&tree=all

Comment 16

[Martin Stránský [:stransky] (ni? me)]

try: https://treeherder.mozilla.org/jobs?repo=try&revision=be7da679fb6da0f5d8f227a09d560f1b14b878c6

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae204d74a9f7
[Linux] Always create offscreen rendering surface if we're missing native rendering window r=lsalzman,jgilbert
https://hg.mozilla.org/integration/autoland/rev/5692d5a1b237
[Linux] remove disable rendering, remove map/unmap handlers r=emilio
https://hg.mozilla.org/integration/autoland/rev/c621729acdc4
[Linux] Simplify OnUnmap handler r=emilio
https://hg.mozilla.org/integration/autoland/rev/f36a7bafc019
[Linux] Remove nsWindow destroy mutex and protect window visibility state instead r=emilio
https://hg.mozilla.org/integration/autoland/rev/dcc81c544c72
[Linux] Rename CompositorWidgetChild::DisableRendering() to CompositorWidgetChild::CleanupResources() and CompositorWidgetChild::EnableRendering() to CompositorWidgetChild::SetRenderingSurface() r=emilio
https://hg.mozilla.org/integration/autoland/rev/d343fe633520
[Linux] Don't suspend rendering to hidden widget as backend code can handle it r=emilio
https://hg.mozilla.org/integration/autoland/rev/c7d6f5ba608c
[Linux] Lock WindowSurfaceProvider between StartRemoteDrawingInRegion() and EndRemoteDrawingInRegion() calls r=emilio

Comment 18

[Sandor Molnar[:smolnar]]

Backed out for causing perma mda failures @ test_getUserMedia_basicScreenshare.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/e992e79977545c04b7fef1c5a911c0216e9b4c08

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | dom/media/webrtc/tests/mochitests/test_getUserMedia_basicScreenshare.html | Error executing test: Error: Checking 500,300 against red timed out. Got [0,0,0,255]. Threshold 5.

Failure log reftest

Failure log Mn

Comment 19

[Intermittent Failures Robot]

20 failures in 444 pushes (0.045 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 18
• mozilla-central: 2

Platform and build breakdown:

• linux1804-64-qr: 20
  • debug: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-19&endday=2024-03-19&tree=all

Comment 20

[Intermittent Failures Robot]

20 failures in 409 pushes (0.049 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 19
• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-qr: 19
  • debug: 19
• windows11-64-2009-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-20&endday=2024-03-20&tree=all

Comment 21

[Martin Stránský [:stransky] (ni? me)]

I can reproduce the layout/reftests/margin-collapsing/inline-horizontal-1.html failure, thanks.

Comment 22

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Wayland] Ensure we create EGLWindow for visible MozContainer r?emilio

Depends on D204073

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48c0bac61e6
[Linux] Always create offscreen rendering surface if we're missing native rendering window r=lsalzman,jgilbert
https://hg.mozilla.org/integration/autoland/rev/69d389710699
[Linux] remove disable rendering, remove map/unmap handlers r=emilio
https://hg.mozilla.org/integration/autoland/rev/69770ebd8903
[Linux] Simplify OnUnmap handler r=emilio
https://hg.mozilla.org/integration/autoland/rev/8a52d2e3479d
[Linux] Remove nsWindow destroy mutex r=emilio
https://hg.mozilla.org/integration/autoland/rev/54a6067c4d01
[Linux] Rename CompositorWidgetChild::DisableRendering() to CompositorWidgetChild::CleanupResources() and CompositorWidgetChild::EnableRendering() to CompositorWidgetChild::SetRenderingSurface() r=emilio
https://hg.mozilla.org/integration/autoland/rev/5550caf7701f
[Linux] Don't suspend rendering to hidden widget as backend code can handle it r=emilio
https://hg.mozilla.org/integration/autoland/rev/b6316d0df80a
[Linux] Lock WindowSurfaceProvider between StartRemoteDrawingInRegion() and EndRemoteDrawingInRegion() calls r=emilio

Comment 24

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c48c0bac61e6
https://hg.mozilla.org/mozilla-central/rev/69d389710699
https://hg.mozilla.org/mozilla-central/rev/69770ebd8903
https://hg.mozilla.org/mozilla-central/rev/8a52d2e3479d
https://hg.mozilla.org/mozilla-central/rev/54a6067c4d01
https://hg.mozilla.org/mozilla-central/rev/5550caf7701f
https://hg.mozilla.org/mozilla-central/rev/b6316d0df80a

Comment 25

[Sandor Molnar[:smolnar]]

The assertion failure is still happening as you can see here.
Should we reopen this bug or file a new one?

Comment 26

[Intermittent Failures Robot]

18 failures in 1364 pushes (0.013 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 15
• mozilla-central: 2
• try: 1

Platform and build breakdown:

• linux1804-64-qr: 18
  • debug: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-21&endday=2024-03-21&tree=all

Comment 27

[Martin Stránský [:stransky] (ni? me)]

Will look at it ASAP, Thanks.

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81b0c51c60e1
[Wayland] Ensure we create EGLWindow for visible MozContainer r=emilio

Comment 29

[Martin Stránský [:stransky] (ni? me)]

(In reply to Sandor Molnar[:smolnar] from comment #25)

The assertion failure is still happening as you can see here.
Should we reopen this bug or file a new one?

Let's track it at Bug 1882538.

Comment 30

[Intermittent Failures Robot]

18 failures in 945 pushes (0.019 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 13
• mozilla-beta: 2
• mozilla-central: 1
• try: 2

Platform and build breakdown:

• linux1804-64-qr: 18
  • debug: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-22&endday=2024-03-22&tree=all

Comment 31

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/81b0c51c60e1

Comment 32

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out the latest commit because many crashes with the signature [@ moz_container_wayland_get_egl_window] have been reported after this landed: https://hg.mozilla.org/mozilla-central/rev/e1c37d37e8e47757a40b72a59eca6d4c7415acfa

Crash report: https://crash-stats.mozilla.org/report/index/99f132fc-9ff0-4303-bc97-aaf840240324

MOZ_CRASH Reason: MOZ_DIAGNOSTIC_ASSERT(wl_container->ready_to_draw) (We can't draw to surface!)

Top 10 frames of crashing thread:

0  libxul.so  moz_container_wayland_get_egl_window  widget/gtk/MozContainerWayland.cpp:726
1  libxul.so  nsWindow::GetNativeData  widget/gtk/nsWindow.cpp:3433
2  libxul.so  mozilla::widget::GtkCompositorWidget::GetEGLNativeWindow  widget/gtk/GtkCompositorWidget.cpp:120
2  libxul.so  mozilla::gl::GLContextEGL::CreateEGLSurfaceForCompositorWidget  gfx/gl/GLContextProviderEGL.cpp:340
2  libxul.so  mozilla::wr::RenderCompositorEGL::CreateEGLSurface  gfx/webrender_bindings/RenderCompositorEGL.cpp:58
2  libxul.so  mozilla::wr::RenderCompositorEGL::Resume  gfx/webrender_bindings/RenderCompositorEGL.cpp:203
3  libxul.so  mozilla::wr::RendererOGL::Resume  gfx/webrender_bindings/RendererOGL.cpp:294
3  libxul.so  mozilla::wr::RenderThread::Resume  gfx/webrender_bindings/RenderThread.cpp:884
3  libxul.so  mozilla::wr::WebRenderAPI::Resume  gfx/webrender_bindings/WebRenderAPI.cpp:774
4  libxul.so  mozilla::wr::RenderThread::RunEvent  gfx/webrender_bindings/RenderThread.cpp:715

Comment 33

[Intermittent Failures Robot]

83 failures in 3791 pushes (0.022 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 72
• mozilla-central: 5
• mozilla-beta: 3
• try: 3

Platform and build breakdown:

• linux1804-64-qr: 82
  • debug: 82
• windows11-64-2009-qr: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2024-03-18&endday=2024-03-24&tree=all

Comment 34

[Martin Stránský [:stransky] (ni? me)]

Looks like we need more patches here, Thanks.

Comment 36

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Use mutex to protect nsWindow::GetNativeData(NS_NATIVE_EGL_WINDOW) r?emilio

Split window configuration (mGdkWindow setup) and compositor resume and use mutex to protect window config only.
That ensures we always have valid mGdkWindow but we don't deadlock if compositor resume is called from map/unmap during
forced EGLSurface update.

Comment 37

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1882779 [Linux] Don't try to get NS_NATIVE_EGL_WINDOW for destroyed windows r?emilio

Depends on D205633

Comment 38

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

For more information, please visit BugBot documentation.

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79a66bf59a9a
[Linux] Use mutex to protect nsWindow::GetNativeData(NS_NATIVE_EGL_WINDOW) r=emilio
https://hg.mozilla.org/integration/autoland/rev/ba04f6471cad
[Linux] Don't try to get NS_NATIVE_EGL_WINDOW for destroyed windows r=emilio

Comment 41

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/79a66bf59a9a
https://hg.mozilla.org/mozilla-central/rev/ba04f6471cad

Comment 42

[Intermittent Failures Robot]

Summary

1 failures in 4309 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform and build breakdown:

• windows11-64-2009-qr: 1
  • debug: 1

Table

	no_variant
windows11-64-2009-qr--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2025-02-03&endday=2025-02-09&tree=all

Comment 43

[Intermittent Failures Robot]

1 failures were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-release: 1

Table

	swr
linux2404-x86_64/opt	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1882779&startday=2025-10-13&endday=2025-10-19&tree=all