1882998 - [Wayland Proxy] Fail if we can't connect to compositor for some time

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Fail if we can't connect to compositor for some time.

Comment 1

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1882998 [Wayland Proxy] Fail if we can't connect to compositor for some time r?emilio

Comment 2

[Clément Lefèvre]

I see this bug from the Wayland metabug, got a question: what would be the result of this in the case of a system under heavy load and temporarily unresponsive?

(Wondering, as I've a bug regarding some Firefox crashes on rare occasions, and that might be one of the causes)

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

(In reply to Clément Lefèvre from comment #2)

I see this bug from the Wayland metabug, got a question: what would be the result of this in the case of a system under heavy load and temporarily unresponsive?

(Wondering, as I've a bug regarding some Firefox crashes on rare occasions, and that might be one of the causes)

If we fail to connect to compositor for some time it usually means the connection is already dead as Gtk display init doesn't wait so long.
If Gtk display init fails at _gdk_wayland_display_open() (wl_display_roundtrip() returns -1) Gtk silently switches to X11 and proxy us not used at all.
I think in such case we should remove the proxy actually.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1882998 [Wayland] Fallback correctly to X11 if Gtk already switched from Wayland to X11 r?emilio

If Gtk switched from Wayland to X11 during display open phase, do that change on browser side too.
It may happen if WAYLAND_DISPLAY is wrongly set or compositor is slow or so.

Depends on D203249

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO, back on Feb 17)]

Attachment: Bug 1882998 [Wayland Proxy] Minor logging tweak r?emilio

Depends on D203259

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c65e9ed99a1
[Wayland Proxy] Fail if we can't connect to compositor for some time r=emilio
https://hg.mozilla.org/integration/autoland/rev/3645593a0f45
[Wayland] Fallback correctly to X11 if Gtk already switched from Wayland to X11 r=emilio
https://hg.mozilla.org/integration/autoland/rev/8a586af3529e
[Wayland Proxy] Minor logging tweak r=emilio

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2c65e9ed99a1
https://hg.mozilla.org/mozilla-central/rev/3645593a0f45
https://hg.mozilla.org/mozilla-central/rev/8a586af3529e