Open Bug 1883159 Opened 4 months ago Updated 2 months ago

Add separate 'delete' and 'edit' subpages to about:profiles-new

Categories

(Toolkit :: Startup and Profile System, enhancement)

enhancement

Tracking

()

125 Branch

People

(Reporter: jhirsch, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-profile-management] )

In bug 1883155, we added the profiles submenu with an entry for the current profile, containing edit and delete buttons that both just redirected to the about:profiles-new page.

Here, we want to create placeholder sub-pages in about:profiles-new, and have the edit and delete buttons navigate to the correct sub-page.

We'll also want the "create new profile" button (bug 1883157) to launch a profile into the correct sub-page.

I'm not sure how to implement addressable sub-pages in about pages. Do we use a query string? a hash? something else?

The edit page should show the current profile's name, and allow it to be edited and saved. The Actor will need to call into the ProfileService to get and set the name. Note that the UX calls for the user to not have to hit a save button after making edits, so we'll need to do something clever-ish to make sure we auto-save after the user's done typing, or before they leave the page.

The delete page...deleting the currently running profile will be complicated. I think we'll have to do something like, schedule a background task to delete the profile after shutdown, then shutdown. But we'll wait and do that in a later bug. For now, it's enough to have a "really delete" button in the page that calls a placeholder function that we can mock out from tests to verify it's working.

There will also be a followup bug to deal with adding avatars and themes, but we'll need the new profile store before that can happen.


References:

Eng doc: https://docs.google.com/document/d/1R2462LEfagLI1y37hO90zlcKnGgQbhZvLG3lGtWEN84/edit?usp=sharing

Product MVP doc: https://docs.google.com/document/d/1am6FmSPBi0zTtGQZbINEUjDsvgD2BuS8ho-ERUB624w/edit

Very WIP Figma link: https://www.figma.com/file/FXL6eQGaZ3MI50XebsCIJ8/Profiles?type=design&node-id=5203-5997&mode=design&t=CtvoRiYXfBmkZhDd-0

Whiteboard: [fidefe-profile-management]
Component: Profiles → Startup and Profile System
Product: Firefox → Toolkit
Target Milestone: --- → 125 Branch
Whiteboard: [fidefe-profile-management] → [fidefe-profile-management]
You need to log in before you can comment on or make changes to this bug.