1883155 - Add profiles menu and submenu to hamburger menu

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement)

Description

[Jared Hirsch [:jhirsch] (PTO, back 5/28) (he/him) (Needinfo please)]

Attachment: Very WIP figma screenshot of hamburger menu profiles additions

Let's add the (very WIP UX) Profiles UI to the hamburger menu, and also add a gProfiles model as described in the eng doc. We want to avoid making browser.js any bigger, so I guess put it in browser-profiles.js and import that into browser.js. I think we roughly want gProfiles to contain what's in gIdentities in Dave's prototype, at least as a starting point, except don't bother iterating the list of other profiles in this bug. We'll do that in a followup bug.

We want to only show the Profiles entry in the main hamburger menu if the profiles pref is true.
Let’s assume UX will want to put the current profile’s name in the main menu item, so put the current profile’s name in there, without an avatar for now.

Also add the submenu, with the current profile in a big non-clickable menuitem at the top (I guess just show the name for now, and edit and delete buttons that just redirect to the about:profiles-new page. Don’t try too hard to style them, as the layout and styling will change.)

Skip listing out the other profiles for now, we’ll do that in another bug.

The submenu should also have a no-op "Create a new profile" menu item. We'll file a separate bug for its behavior, because we'll need to create and launch a profile with the first run homepage overridden to our about page, which will require some exploration. But, for now, I guess add something to gIdentities so we can mock it out and verify it's called when the menu item is clicked.

The submenu should also have a "Manage profiles" menu item that loads about:profiles-new when clicked.

---

References:

Eng doc: https://docs.google.com/document/d/1R2462LEfagLI1y37hO90zlcKnGgQbhZvLG3lGtWEN84/edit?usp=sharing

Product MVP doc: https://docs.google.com/document/d/1am6FmSPBi0zTtGQZbINEUjDsvgD2BuS8ho-ERUB624w/edit

Very WIP Figma link: https://www.figma.com/file/FXL6eQGaZ3MI50XebsCIJ8/Profiles?type=design&node-id=5203-5997&mode=design&t=CtvoRiYXfBmkZhDd-0

---

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1883155 - Add profiles menu to hamburger menu. r=jhirsch,mossop

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f647bca33ff
Add profiles menu to hamburger menu. r=mossop,fluent-reviewers,desktop-theme-reviewers,cmkm,bolsson

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failures on browser_sentence_case_strings.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/9b6db778a341d331d86980124f28c22bdc75048d
Log link: https://treeherder.mozilla.org/logviewer?job_id=449930438&repo=autoland&lineNumber=4338

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a491cb4375a
Add profiles menu to hamburger menu. r=mossop,fluent-reviewers,desktop-theme-reviewers,cmkm,bolsson

Comment 5

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/8a491cb4375a