1883162 - Update profiles app menu items to use Selectable Profiles

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, enhancement, P1)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Once selectable profiles are available in the SelectableProfileService, we'll need to revise the list shown in the profiles submenu to only show profiles linked to the current profile, and to also launch new profiles as linked to the current profile.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: WIP: Bug 1883162 - Update profiles appmenu

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1883162 - Update profiles app menu to latest design using selectable profiles. r?niklas

Longish commit here with some notes. I just noticed the delete icon should
be removed from the subview; I'll handle that before landing.

Note for reviewers - if there are 0 or 1 profiles, we show something
different in the app menu vs. 2+ profiles. See the Figma for details,
but in short:

• Case 1: Profiles disabled, the menu item shouldn't be visible
• Case 2: Profiles enabled, but either haven't created a selectable profile
  yet, or only have 1 profile: show "Profiles" in menu item, limited
  view in the submenu panel.
• Case 3: Profiles enabled, 2+ selectable profiles. Show avatar +
  profile name in the menu item, full view in the submenu panel.

I've resorted to null-checking SelectableProfileService.currentProfile
in several spots, but I thought it should never be null--am I right? If
so, we should file a bug to figure out what to do.

This patch is based on a WIP SVG commit. I'm hoping UX can give us revised
SVG avatars with the background circle included in the SVG. For now it's
helpful in testing the flows. Also updated the new profile creation code
to pick a random avatar.

Here we respond to "manage profiles" by opening the profile selector in
a tab. Waiting to hear from UX if that's OK or if a separate window is
needed.

Thoughts welcome on tests needed to land here, thanks.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7719ffbcf2e
Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_sentence_case_strings.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/4b8c994cd14575f41343cea0b5cbaaa71879ccb1

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_sentence_case_strings.js | Test timed out

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f702c1947c9
Update profiles app menu to latest design using selectable profiles. r=niklas,fluent-reviewers,desktop-theme-reviewers,bolsson,dao

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f702c1947c9