1883209 - [wayland] XDG annotation is not freed with native menubar enabled

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1883184 introduced a call to xdg_dbus_annotation_manager_v1_create_surface, but nothing calls the equivalent _delete.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:uhhadd, since you are the author of the regressor, bug 1883184, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883184

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox125 (nightly). We have limited time to fix this, the soft freeze is in 7 days. However, the bug still isn't assigned.

:gcp, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 4

[Gian-Carlo Pascutto [:gcp]]

Emilio, the regressing bug says the feature is disabled by default. So is this leak an actual issue? If it is, we probably need to back it out?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1883209 - Destroy wayland annotation object. r=stransky

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1883209 - Disable harder wayland's appmenu support. r=stransky

Until it has a final shape, at least, since there's ongoing work and
discussion in the MR.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Yes, it's not enabled by default.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/655c9f682b98
Destroy wayland annotation object. r=stransky
https://hg.mozilla.org/integration/autoland/rev/1c5001e4717c
Disable harder wayland's appmenu support. r=stransky

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/655c9f682b98
https://hg.mozilla.org/mozilla-central/rev/1c5001e4717c

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1883184