Open Bug 1419151 Opened 5 years ago Updated 9 days ago

Firefox does not support KDE Plasma 5.9.x+ global menu

Categories

(Core :: Widget: Gtk, defect, P5)

Product:
Core
Component:
Widget: Gtk
Version:
57 Branch
Platform:
Unspecified
Linux
Type:
defect

Tracking

()

Status:
UNCONFIRMED

People

(Reporter: vbspam, Unassigned)

References

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/62.0.3202.89 Chrome/62.0.3202.89 Safari/537.36

Steps to reproduce:

1. Install most recent Ubuntu
2. Install KDE suite including Plasma 5.9x+ and activate global menu
3. Install most recent Firefox (version 57 at the time of reporting)
4. Run Firefox and wait until it starts



Actual results:

There is global menu visible, but can't be clicked or used in any way.


Expected results:

Firefox should be able provide its application menu through the KDE Plasma global menu panel/applet. The same way as it worked in KDE Plasma 4.x or the same way as it is working in other applications such as Chromium.
Summary: Firefox do not support KDE Plasma 5.9.x+ global menu → Firefox does not support KDE Plasma 5.9.x+ global menu
Component: Untriaged → Widget: Gtk
OS: Unspecified → Linux
Product: Firefox → Core
what is "KDE Plasma global menu panel/applet" ?
(In reply to firefox@firemail.cc from comment #1)
> what is "KDE Plasma global menu panel/applet" ?

I am sorry but I did not get the point of your question.

Summary of my issue is that Mozilla SW (Thunderbird, Firefox, etc.) does not support KDE 5 global menu (actually at least in versions 5.9-5.12).

Could you be more specific?
Recently I noticed that there is workaround the brave KDE guys provided, which introduces kind of global menu proxy. Global menu proxy should bring my required functionality for applications which does not want to support the global menu natively in KDE.
(In reply to VaBi from comment #3)
> Recently I noticed that there is workaround the brave KDE guys provided,
> which introduces kind of global menu proxy. Global menu proxy should bring
> my required functionality for applications which does not want to support
> the global menu natively in KDE.

I forgot to mention that it should be available in the KDE Plasma 5.13.

Yes, issue still exists.
Plasma 5.17
FF 74.0

I just setup global menu in KDE & it's empty for firefox.

(In reply to 5n00p4eg from comment #7)

Yes, issue still exists.
Plasma 5.17
FF 74.0

I just setup global menu in KDE & it's empty for firefox.

I'm using Plasma 5.17 too (in Fedora 31), can confirm this issue still persist.

I have to say Mozilla SW depends on the appmenu-gtk-module, which is directly related to the Firefox support for this feature.
However, when I use any other GTK+ based SW, KDE shows the global menu. I'm aware GTK apps print exactly the same "Gtk-message" ("Failed to load module "appmenu-gtk-module") when their are running in a non-GTK based workspace/framework. For example, when I start Brave Browser I get this warning, but the KDE global menu works as intended. I can't say the same about Firefox (this happens with Thunderbird too)

This is something I notice every day using Firefox on KDE with global menu. All other GTK and QT apps export their menus properly, Firefox is the only one that refuses to cooperate. This would also be an issue on Unity or any other DE with a global menu. I'm surprised this hasn't gotten more attention – I guess global menu has gone out of fashion lately?

These patches seem to make it work: https://gitlab.com/Thaodan/firefox-kde-opensuse/ . But I would need to custom compile every time since I use Debian. Any interest in addressing this upstream rather than leaving it for the distros to hack together workarounds?

Hi, please do support this! Although one does not use the "File Edit View . . ." menu bar much while browsing the Internet, it would still be nice to have the global menu rather than the space (which is supposed to be the menu) being empty.

I'm using KDE Plasma 5.22.4 on Manjaro.

Will look at it. It would be great if SUSE fols submit that by phabricator (phabricator.services.mozilla.com/) so we can merge it to Firefox.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #11)

Will look at it. It would be great if SUSE fols submit that by phabricator (phabricator.services.mozilla.com/) so we can merge it to Firefox.

Hey I'm the maintainer of that package mentioned in comment #9. The patch is from Chris Coulson with updates from Rico Tzschichholz.
The original bug for this was bug 19899. the follow up is bug 1546004.
I can submit that patch thou if the original authors don't want to do that.

I have the patch in my package since Firefox 38(2015), its working flawless ever since.

I tested this version (I did backport to 93) but seems to work on X11 only, right? Is there any way to support Wayland?

(In reply to Martin Stránský [:stransky] (ni? me) from comment #13)

I tested this version (I did backport to 93) but seems to work on X11 only, right? Is there any way to support Wayland?

There's work to make DBusMenu working on Wayland.
Read here:
https://bugs.kde.org/show_bug.cgi?id=424485
https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/33

Hi, I'm the author of the aforementioned Wayland protocol (now https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/52) that would allow for app menu support under Wayland, was looking at maybe getting an implementation for Firefox after getting a Chromium implementation working, and ran across this bug report. I'm curious what the status of the DBus functionality itself being upstreamed from the Canonical/SUSE patches is, since obviously we can't annotate a Firefox window as having an appmenu object that doesn't exist :)

(In reply to uhhadd from comment #16)

Hi, I'm the author of the aforementioned Wayland protocol (now https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/52) that would allow for app menu support under Wayland, was looking at maybe getting an implementation for Firefox after getting a Chromium implementation working, and ran across this bug report. I'm curious what the status of the DBus functionality itself being upstreamed from the Canonical/SUSE patches is, since obviously we can't annotate a Firefox window as having an appmenu object that doesn't exist :)

Hello,

I think there isn't any related patches upstreamed from Canonical/SUSE. I tried to apply https://gitlab.com/Thaodan/firefox-kde-opensuse/blob/master/unity-menubar.patch locally but that does not work under Wayland (and afaik also failed to apply to nightly).

Anyway, I'm happy to help with upstreaming any of these changes, they just need to be submitted via Phabricator (https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html) and preferably divided to smaller patches - just ask me for review.

Thanks.

(In reply to Martin Stránský [:stransky] (ni? me) from comment #17)

(In reply to uhhadd from comment #16)

Hi, I'm the author of the aforementioned Wayland protocol (now https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/52) that would allow for app menu support under Wayland, was looking at maybe getting an implementation for Firefox after getting a Chromium implementation working, and ran across this bug report. I'm curious what the status of the DBus functionality itself being upstreamed from the Canonical/SUSE patches is, since obviously we can't annotate a Firefox window as having an appmenu object that doesn't exist :)

Hello,

I think there isn't any related patches upstreamed from Canonical/SUSE. I tried to apply https://gitlab.com/Thaodan/firefox-kde-opensuse/blob/master/unity-menubar.patch locally but that does not work under Wayland (and afaik also failed to apply to nightly).
The patches are from Canonical and the upstream of them is here:
http://bazaar.launchpad.net/~mozillateam/firefox/firefox-trunk.head/view/head:/debian/patches/unity-menubar.patch

Great. We need to get them submitted via phabricator and go through review process in Firefox. Can anyone from Canonical submit them?

Curious, why would it be needed? IIRC we did a bunch of work to have native menus on macOS, and NativeMenu should be sorta straight-forward to implement on GTK?

Ah, that only be needed for context menus.

See also bug 1149972. Maybe that one can be closed now if GNOME doesn't use a menu bar, or it could be marked as a duplicate of this.

Did you get the patch via phabricator?
This is a big disadvantage of Firefox and Thunderbird. They are the only applications on my desktop that do not work with the global menu of KDE Plasma. Because switching is not an option, I would very much appreciate if mozilla software supported the global menu.
Firefox and Thunderbird are one of the most used OSS on the Linux Desktop.

Severity: normal → S3

The severity field for this bug is relatively low, S3. However, the bug has 13 votes.
:stransky, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Flags: needinfo?(stransky)

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Flags: needinfo?(stransky)

It is still relevant for any one using Globalmenu. The only issue is right now that the GTK implementation of it depends on X11.

Also voting for this, currently it doesn't even appear in the global menu for me in plasma 5.27
Operating System: Arch Linux
KDE Plasma Version: 5.27.2
KDE Frameworks Version: 5.103.0
Qt Version: 5.15.8
Kernel Version: 6.2.2-arch2-1 (64-bit)
Graphics Platform: Wayland
Firefox 110

Thanks!

You need to log in before you can comment on or make changes to this bug.