1883353 - Require to always drop directory locks explicitly

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

This is needed for bug 1903186.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1883353 - Require to always drop directory locks explicitly; r=#dom-storage

Until now, directory locks were dropped when the last strong reference was
removed or after calling Drop explicitly. The dependency on ref-counting makes
it less obvious when directory locks are dropped for real and it's also
difficult to release them asynchronously eventually. This patch removes the
directory lock unregistration from the destructor, so from now on, directory
locks must be always dropped explicitly.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dca9f407ea90
Require to always drop directory locks explicitly; r=dom-storage-reviewers,jari

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1883353 - Add testing for DirectoryLock::Drop; r=#dom-storage

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a98a57009510
Add testing for DirectoryLock::Drop; r=dom-storage-reviewers,jari

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1883353 - Change DirectoryLock::Drop to be asynchronous; r=#dom-storage

For now, asynchronous Drop is only needed for replacing counting of pending
clear/shutdown storage operations with evaluation of existing directory locks.
In future, asynchronous Drop will also allow to do IO, for example if we decide
to wait for saving of origin access time to be finished.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/dca9f407ea90

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a98a57009510

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1883353 - Convert a debug only assertion in DirectoryLockImpl dtor to a diagnostic assertion; r=#dom-storage

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3c8afb03c48d
Convert a debug only assertion in DirectoryLockImpl dtor to a diagnostic assertion; r=dom-storage-reviewers,jstutte

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/3c8afb03c48d

Comment 11

[Phabricator Automation]

Comment on attachment 9407629 [details]
Bug 1883353 - Change DirectoryLock::Drop to be asynchronous; r=#dom-storage

Revision D197298 was moved to bug 1903186. Setting attachment 9407629 [details] to obsolete.

Comment 12

[Jan Varga [:janv]]

Fixed.