1902941 - Crash in [@ mozilla::Variant<T>::as] from DirectoryLockImpl::Overlaps

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, defect, P2)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/658f2fc6-159f-49d1-a70e-bf9d80240616

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(is<N>())

Top 10 frames:

0  xul.dll  mozilla::Variant<mozilla::dom::quota::OriginScope::Origin, mozilla::dom::quot...  mfbt/Variant.h:771
0  xul.dll  mozilla::detail::VariantImplementation<unsigned char, 3, mozilla::dom::quota:...  mfbt/Variant.h:189
0  xul.dll  mozilla::detail::VariantImplementation<unsigned char, 2, mozilla::dom::quota:...  mfbt/Variant.h:279
1  xul.dll  mozilla::dom::quota::DirectoryLockImpl::Overlaps(mozilla::dom::quota::Directo...  dom/quota/DirectoryLockImpl.cpp:78
1  xul.dll  mozilla::dom::quota::DirectoryLockImpl::MustWaitFor(mozilla::dom::quota::Dire...  dom/quota/DirectoryLockImpl.cpp:103
1  xul.dll  mozilla::dom::quota::DirectoryLockImpl::AcquireInternal()  dom/quota/DirectoryLockImpl.cpp:218
2  xul.dll  xul.dll@0x108ec3e
3  xul.dll  mozilla::dom::quota::QuotaManager::OpenStorageDirectory(mozilla::dom::Nullabl...  dom/quota/ActorsParent.cpp:5149
4  xul.dll  mozilla::dom::quota::OpenStorageDirectoryHelper<mozilla::dom::quota::Resolvab...  dom/quota/OriginOperations.cpp:882
5  xul.dll  mozilla::dom::quota::ClearOriginOp::OpenDirectory()  dom/quota/OriginOperations.cpp:2162

This signature is horrible (and we should really improve the signature generation...) but it looks like there's a recent resurgence in Nightly for it, all or almost all via DirectoryLockImpl::Overlaps() doing some stuff with variants.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Topcrash in Nightly 129.

Comment 2

[Jan Varga [:janv]]

We shouldn't see this anymore after https://phabricator.services.mozilla.com/D213917

Comment 3

[Andrew McCreight [:mccr8]]

It does look like it went away at around the time that landed.