1883355 - [wdspec] Create test for recommended preferences of protocols supported by the Remote Agent

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is a follow-up from bug 1882748 which requires some extra wdspec tests for the various Remote Agent protocols. It should iterate over all the remote.active-protocols values and test that the common recommended preferences are always applied.

The tests aren't that easy to write because:

• We cannot use Marionette (WebDriver classic) to start the browser because it would have already set these preferences
• We should use a new profile with the common user preferences as defined by wptrunner
• Transfer these common user preferences via the full_configuration to pytest
• Allow the Browser class (and fixture) to accept a new_profile argument and set the default set of preferences

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1883355 - [wdspec] Refactor Mozilla specific fixtures for additional helpers.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1883355 - [wdspec] Add a fixture to create a fresh Firefox profile without cloning current preferences.

Depends on D203724

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1883355 - [wdspec] Added Mozilla specific test for recommended preferences for Remote Agent.

Depends on D203725

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Somehow the new test fails on Windows debug only:
https://treeherder.mozilla.org/jobs?repo=try&revision=6d1952f6caa82b7be3c374b6849954820b0e34f6&selectedTaskRun=faWzI1a-QB6gmO01QaJ2jA.0

I'm going to push with trace level logs enabled to see what might cause it:
https://treeherder.mozilla.org/jobs?repo=try&revision=cf295c8ef1b51bb95723fe557f2fcfe9d2989d17

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We have actually set all the recommended preferences, including remote.prefs.recommended.applied one. However, despite writing the initial batch of preferences to the file, the one we need isn't there yet. Consequently, Firefox will eventually rewrite the preferences, and we must wait until then.

I've pushed another try build:
https://treeherder.mozilla.org/jobs?repo=try&revision=9818d27ab7ee8526e0dde01f098025d866ce3192

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e813fc56c68
[wdspec] Refactor Mozilla specific fixtures for additional helpers. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/2208179cab4b
[wdspec] Add a fixture to create a fresh Firefox profile without cloning current preferences. r=webdriver-reviewers,jgraham
https://hg.mozilla.org/integration/autoland/rev/12faf3d7baff
[wdspec] Added Mozilla specific test for recommended preferences for Remote Agent. r=webdriver-reviewers,jdescottes

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5e813fc56c68
https://hg.mozilla.org/mozilla-central/rev/2208179cab4b
https://hg.mozilla.org/mozilla-central/rev/12faf3d7baff