1883367 - Disable editor commands for read-only editors

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[John Bieling]

I encountered this bug while working on Thunderbird Bug 1758469.

STR:

• Run latest Thunderbird with https://phabricator.services.mozilla.com/D202887 applied (Locking is currently broken entirely, I hope the fix lands soon, so you can test with Daily: Go to https://www.thunderbird.net/en-US/thunderbird/all/ and scroll to the bottom and select "Daily Channel" on the right.)
• Install the attached add-on (which helps to see the compose editor in the read-only state).
• Create a new message (make sure it is an HTML message - which is default - and not a plain text message).
• Enter a "to" address (can be a dummy).
• Enter a subject.
• Enter some text in the message body.
• Click on "Send". The installed add-on will block sending and instead lock the composer.
• Observe that neither the subject nor the body can be modified.
• Observe however, that text in the body can be selected (which is not an error), and the bold command is still enabled
  • clicking the bold icon modifies the composer
  • using shortcuts (CTRL+B) modifies the composer

The proposed patch adds a check for EditorBase::IsModifiable() to EditorCommand::IsCommandEnabled and disables all editor commands, when the editor is read-only

Comment 1

[John Bieling]

Attachment: lock.xpi

Comment 2

[John Bieling]

Attachment: Bug 1883367 - Make isSelectionEditable() return false, if the editor is readOnly. r=masayuki

Comment 3

[John Bieling]

Attachment: Bug 1883367 - Disable editor commands for read-only editors. r=masayuki

The purpose of this patch is to prevent users to make changes to
read-only editors.

This patch forces IsCommandEnabled() to return false for read-only
editors for "standard" editor commands that could have an associated
icon or menu entry and are therefore user-accessible.

Advanced internal editor commands are not touched.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd6b961d3b69
Disable editor commands for read-only editors. r=masayuki

Comment 5

[Cristian Tuns]

Backed out for causing mochites failures in test_command_state_when_readonly_in_chrome.html

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | editor/libeditor/tests/test_command_state_when_readonly_in_chrome.html | Enabled state of command cmd_paste should be TRUE for {"content":"empty","selected":true,"readonly":false} - got false, expected true

Comment 6

[John Bieling]

Removing the broken new test (it is not testing new behavior, but is wrongly testing existing behavior)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c3d04d02bf0
Disable editor commands for read-only editors. r=masayuki

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/2c3d04d02bf0