1758469 - onBeforeSend does not lock compose window completely

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Alexander Bergmann]

Attachment: test.xpi

The event messenger.compose.onBeforeSend() does not lock the compose window completely. It is still possible to interact with the menu and the toolbar buttons.

For example: You can still change the delivery format or the priority. And you can even fiddle with the editor, i.e. the body of the message, via "Tools -> Quote Message". Multiple menu entries are still enabled, but seem to have no effect.

I think the compose window should get locked completely in this case - including locking all menus and toolbars.

Comment 1

[Alexander Bergmann]

There are multiple places where a global locking of the message compose window is needed, e.g.: Bug 1758469 and Bug 1758470. And in case of an "locking overlay" in the compose window as an alternative to modal dialogs - discussed in Bug 1607192. The solution should ideally cover all these use-cases.

Comment 2

[Teal Dulcet [:tdulcet] (TB Council)]

Also see: Bug 1751897

Comment 3

[John Bieling (:TbSync)]

Attachment: lock.xpi

Comment 4

[John Bieling (:TbSync)]

Most of the issues have been fixed in Bug 1862405 already. Added lock.xpi which does not send mails and allows to unlock the composer again.

The bold, underline and some other formatting buttons are available even if the editor is read-only, which I address in Bug 1883367.

I guess a disabled compose action toolbarbutton should also not react on clicks.

Anything else?

Will use this bug to verify all elements are locked and add tests.

Comment 5

[John Bieling (:TbSync)]

Attachment: Bug 1758469 - Fix compose window not being fully locked. r=#thunderbird-reviewers

This is a continuation of the effort started in D202887. Here we add
tests to verify the composer elements being correctly locked and
unlocked again.

The following still incorrect cases are fixed:

• the spelling button is now correctly locked
• action buttons are now correctly locked

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29a7191ced1a
Fix compose window not being fully locked. r=freaktechnik