1883370 - [Windows] XUL notification does not stay frontmost (it can now be hidden behind other windows)

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

Managing window properly is hard 🥲

Just got a report from a user that their notification now goes behind other windows, and mozregression says it's a regression from bug 1870512.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1870512

Comment 2

[Bob Hood [:bhood]]

Daniel, can we please get Priority/Severity settings applied here? It will help with release management triage.

Comment 3

[Daniel Holbert [:dholbert]]

(In reply to Kagami [:saschanaz] (they/them) from comment #0)

Just got a report from a user that their notification now goes behind other windows

Do we have any more info on environment (i.e. affected system configurations) and/or STR?

Comment 4

[Kagami Rosylight [:saschanaz] (they/them) (OOO until 2024-10-06)]

(In reply to Daniel Holbert [:dholbert] from comment #3)

(In reply to Kagami [:saschanaz] (they/them) from comment #0)

Just got a report from a user that their notification now goes behind other windows

Do we have any more info on environment (i.e. affected system configurations) and/or STR?

Yup.

1. On Windows 11, set alerts.useSystemBackend=false
2. Open https://www.bennish.net/web-notifications.html
3. Click Authorize and then Show
4. Bring some other window over the notification and see if it goes behind the window

Comment 5

[Daniel Holbert [:dholbert]]

Thanks. I can repro. Tentatively classifying as S3, in part given that it's a non-default configuration (requiring an about:config flip).

Just chatted with Emilio and he thinks it's a pretty easy fix, though.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1883370 - Use WS_EX_TOPMOST for alerts. r=#win-reviewers,saschanaz

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83be82982f3b
Use WS_EX_TOPMOST for alerts. r=saschanaz

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/83be82982f3b

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9389707 [details]
Bug 1883370 - Use WS_EX_TOPMOST for alerts. r=#win-reviewers,saschanaz

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 4
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-liner
• String changes made/needed: none
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

:emilio this doesnt graft cleanly, do we also need bug 1880394?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1883370 - [beta] Use WS_EX_TOPMOST for alerts.

Comment 13

[Phabricator Automation]

Uplift Approval Request

• Code covered by automated testing: no
• Risk associated with taking this patch: low
• Needs manual QE test: yes
• Explanation of risk level: one-liner
• Is Android affected?: no
• Fix verified in Nightly: yes
• String changes made/needed: none
• Steps to reproduce for manual QE testing: comment 4
• User impact if declined: comment 0

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9389707 [details]
Bug 1883370 - Use WS_EX_TOPMOST for alerts. r=#win-reviewers,saschanaz

Rebased version above.

Comment 15

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/c67065d1e98e

Comment 16

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 125.0a1 (2024-03-10) on Windows 10x64 and 11 by following steps from comment 4. The notification window goes behind other windows (Control Panel, Folder, Mail Windows application).

The issue is verified fixed with Firefox 125.0a1 (2024-03-10) and 124.0b9 on Windows 10x64 and 11 using the same steps. The notification remains on top after trying to hide it with other windows.

However, I can still see this issue happening on macOS 12 and Ubuntu 23.10 Wayland with fixed builds by using steps from comment 4. On macOS 12 this issue is not reproducible with Firefox 123.0a1 (2023-12-18), a build before the regressor (bug 1870512) but the issue reproduces on Ubuntu 23.10 with a build before the regressor (bug 1870512), so on Ubuntu 23.10 this may be happening for a long time. Should I file separate issues for macOS and Ubuntu 23.10 and close this one as verified for Windows only? Thank you in advance!

Comment 17

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Sorry for the spam, I mistakenly modified the statuses.

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Yes, please, that sounds gret.

Comment 19

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Thank you! I opened bug 1884635 for macOS which is a regression from bug 1870512 and bug 1884637 for Ubuntu, but on Ubuntu 23,10, this issue is not a regression from bug 1870512. Closing this for Windows only based on the above comments.