1884635 - [macOS] XUL notification does not stay frontmost

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: Screen Recording 2024-03-11 at 11.50.50.mov

Found in

• 125.0a1 (2024-03-10)

Affected versions

• 125.0a1 (2024-03-10)
• 124.0b9
• 123.0.1

Tested platforms

• Affected platforms: macOS 12, 14
• Unaffected platforms: Windows 10x64, Windows 11 (fixed by bug 1883370)

Preconditions

• set alerts.useSystemBackend=false

Steps to reproduce

1. Open https://www.bennish.net/web-notifications.html
2. Click Authorize and then Show
3. Bring some other window over the notification and see if it goes behind the window

Expected result

• The notification does not hide beside other windows.

Actual result

• Notification does not stay frontmost.

Regression range

• Mozregression points bug 1870512.

Additional notes

• Attached a screen recording.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1870512, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1884635 - Misc nsCocoaWindow clean-ups. r=#mac-reviewers

No behavior change. Mostly fixing clang-tidy nits and using dot for
property accesses, which is a bit more readable.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1884635 - Make alert windows appear over other app windows. r=#mac-reviewers

This was roughly what happened via the popup menu level before the
regressing bug.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81ef5d400f99
Misc nsCocoaWindow clean-ups. r=mac-reviewers,bradwerth
https://hg.mozilla.org/integration/autoland/rev/723cfc34519f
Make alert windows appear over other app windows. r=mac-reviewers,bradwerth

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/81ef5d400f99
https://hg.mozilla.org/mozilla-central/rev/723cfc34519f

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Alexandru Trif, Desktop QA [:atrif]]

Verified fixed with Firefox 125.0a1 (2024-03-17) on macOS 12 and macOS 13 by using steps from comment 0.