1883371 - Enable ESLint rule no-console on production code

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

As discussed in bug 1881519, we want to enable ESLint rule no-console across our production code, to help ensure that we're not unnecessarily/unintentionally spamming the console, and that we're thinking about the correct log levels for messages.

We are allowing console.error, console.warn and console.createInstance. Everything else will be disallowed eventually. For now, we'll turn the rule off for existing failures and enable those over time.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1883371 - Add a general configuration for rules specific for all tests. r?Mossop!

This gives us the option to specify rule variations for all tests without having to copy across the configurations.

More importantly, we can also apply this to anything under /test/ or /tests/ and so we can catch utils and other files that the specific test configurations don't already catch.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1883371 - Enable ESLint rule no-console on production code. r?Mossop!

Allow for console.error, console.warn and console.createInstance, but fail for everything else.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d78ef7334788
Add a general configuration for rules specific for all tests. r=mossop
https://hg.mozilla.org/integration/autoland/rev/013efc5f9131
Enable ESLint rule no-console on production code. r=mossop,webcompat-reviewers,devtools-reviewers,omc-reviewers,twisniewski,nchevobbe,aminomancer

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d78ef7334788
https://hg.mozilla.org/mozilla-central/rev/013efc5f9131