Closed Bug 1883846 Opened 8 months ago Closed 8 months ago

Port bug 1883371 - Enable ESLint rule no-console on production code

Categories

(Thunderbird :: Upstream Synchronization, task)

Tracking

(thunderbird_esr115 unaffected, thunderbird124 unaffected)

RESOLVED FIXED
125 Branch
Tracking Status
thunderbird_esr115 --- unaffected
thunderbird124 --- unaffected

People

(Reporter: mkmelin, Assigned: mkmelin)

References

Details

Attachments

(2 files)

Assignee: nobody → mkmelin+mozilla

Remove some of things that shoudn't really be logged.
Some usage were in try-catches that should not reasonably throw.
Upgraded many debug/logs to warn - when appropriate.

Status: NEW → ASSIGNED
Target Milestone: --- → 125 Branch

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d6acfececd8d
Port bug 1883371 - Enable ESLint rule no-console on production code. r=aleca

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED

Magnus, could you please restore the more detailed logging in GPGMELib.jsm which you removed here?
I frequently refer people to those log messages.

Flags: needinfo?(mkmelin+mozilla)

Adding back debugging infor for GPGMELib.
This should not be using global console for debug info, if such info is warranted.
For error cases, we can log errors. To see debug only info, people should set openpgp.loglevel to All.

Flags: needinfo?(mkmelin+mozilla)
Pushed by mkmelin@iki.fi: https://hg.mozilla.org/comm-central/rev/c343f48fecbf Rework/reinstate the GPGMELib debug output. r=kaie
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: