Open Bug 1883450 Opened 2 months ago Updated 2 months ago

Figure out what to do with vendored dependencies in aboutwelcome and asrouter

Categories

(Firefox :: Messaging System, task, P2)

Product:
Firefox
Component:
Messaging System
Type:
task

Tracking

()

People

(Reporter: aminomancer, Unassigned)

References

(Blocks 1 open bug)

Details

asrouter and aboutwelcome currently require all the same vendored dependencies as newtab:

  "dependencies": {
    "@fluent/bundle": "0.18.0",
    "@fluent/react": "0.15.2",
    "react": "16.13.1",
    "react-dom": "16.13.1",
    "react-redux": "7.2.6",
    "redux": "4.1.2"
  },

But they are using the output of newtab's vendor.js script, resource://activity-stream/vendor/react.js. So I'm not sure any of this is necessary. If it is, we still aren't using redux in aboutwelcome or asrouter.

Also, we aren't using fluent/react or fluent/bundle anywhere anymore. It seems to have been removed when we disentangled ASRouterAdmin from the newtab bundle. So we should remove this dependency.

See Also: → 1868838
See Also: → 1877199

This and bug 1877199 should be done in one patch - and look at newtab at the same time.

Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.