Closed Bug 1868838 Opened 5 months ago Closed 3 months ago

Move the rest of the ASRouter code out from browser/components/newtab into browser/components/asrouter

Categories

(Firefox :: Messaging System, task, P2)

Product:
Firefox
Component:
Messaging System
Type:
task
Points:
8

Tracking

()

Status:
RESOLVED FIXED
Milestone:
124 Branch
Iteration:
124.1 - Jan 22 - Feb 2
Tracking Flags:
Tracking Status
firefox124 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

(Blocks 4 open bugs, Regressed 1 open bug)

Details

Attachments

(29 files)

Bug 1868838 - Move ASRouterDefaultConfig into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouterTriggerListeners into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouterPreferences into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouterParentProcessMessageHandler into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouterNewTabHook into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouterTargeting into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouter into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move a bunch of ASRouter tests to browser/components/asrouter/tests/unit. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Update babel-jsm-to-commonjs to allow for multiple replacements. r?dmose!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move CFRMessageProvider into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move CFRPageActions into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move RemoteL10n into browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ModalOverlay into browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move Button into into browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move asrouter-utils into browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ImpressionsWrapper and ConditionalWrapper into browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move template-utils into browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouter docs into browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move messaging schemas into browser/components/asrouter. r?pdahiya!,barret!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move ASRouter unit test constants to browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move import-rollouts script into browser/components/asrouter. r?aminomancer!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move OnboardingMessageProvider to browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move PanelTestProvider to browser/components/asrouter/modules. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Update fxms-schemas for new pathing for schemas and modules. r?barret!,ahal!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Move some missed tests, and update documentation for new ASRouter pathing. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Update ASRouter coverage expectations for ModalOverlay to match reality. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Add missing xpcshell.toml file for browser/components/asrouter. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Update codespell.yml and fix linting issues. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1868838 - Fix up browser_all_files_referenced.js. r?pdahiya!
48 bytes, text/x-phabricator-request
Details | Review

In bug 1866802, I created a new component folder, browser/components/asrouter, to house the ASRouterAdmin UI.

There's still some ASRouter stuff under browser/components/newtab:

  1. Anything prefixed with ASRouter under browser/components/newtab/lib
  2. The asrouter.ftl strings live in the newtab locale folder
  3. The ASRouter actors live under browser/components/newtab/actors
  4. The contents of browser/components/newtab/content-src/asrouter
  5. Any ASRouter-related mochitest-browser tests under browser/components/newtab/test/browser
  6. All unit tests under browser/components/newtab/test/unit/asrouter
  7. ASRouter xpcshell unit tests under browser/components/newtab/test/xpcshell/

We should move those things under browser/components/asrouter instead, and finish the decoupling from the newtab codebase.

Priority: -- → P2

Also, per https://phabricator.services.mozilla.com/D195812#inline-1089397, we should make sure that the ASRouter documentation is moved out and updated to the latest state of the world.

Another followups that should be covered as part of 6. All unit tests under browser/components/newtab/test/unit/asrouter from bug description is cleanup unit-entry file in asrouter https://phabricator.services.mozilla.com/D194812#inline-1089364

I've started to work on some of this.

Assignee: nobody → mconley

Split out the asrouter.ftl work to bug 1874970.

See Also: → 1874970

This also moves the ASRouterParentProcessMessageHandler mocha/chai unit test.

Depends on D198869

This causes the mocha/chai tests for newtab to break because of the failure
to import the ASRouterNewTabHook module from within ASRouterParent. This will
get fixed in the next patch in the stack which moves the actors.

Depends on D198870

This requires a change to aboutwelcome's karma webpack packaging so that
resources loaded at "resource:///modules/asrouter/X.sys.mjs" get remapped
to "asroutermodules/X.sys.mjs".

Depends on D198877

Previous patches in the stack had used asroutermodules as an alias to get
at browser/components/asrouter/modules. This patch, however, required adding
an alias to get at asrouter/content-src/components, so asroutermodules was
replaced with a top-level asrouter alias.

Depends on D198880

These don't appear to be used anywhere, but moving them anyways.

Depends on D198883

Attachment #9373568 - Attachment description: Bug 1868838 - Update documentation for new ASRouter pathing. r?pdahiya! → Bug 1868838 - Move some missed tests, and update documentation for new ASRouter pathing. r?pdahiya!
Attachment #9373572 - Attachment description: Bug 1868838 - Fix up browser_all_files_referenced.js and some schema references. r?pdahiya! → Bug 1868838 - Fix up browser_all_files_referenced.js. r?pdahiya!
Blocks: 1877196
Blocks: 1877202
Blocks: 1877204
Blocks: 1877207
Blocks: 1877210
Blocks: 1877198
Blocks: 1877199
Blocks: 1877212
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ee849967df9
Move ASRouterDefaultConfig into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/ba04458b277f
Move ASRouterTriggerListeners into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/dc7f08dbb91c
Move ASRouterPreferences into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/e4493dbebbf3
Move ASRouterParentProcessMessageHandler into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/b8b710219e6b
Move ASRouterNewTabHook into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/6bad52557d04
Move ASRouterTargeting into browser/components/asrouter/modules. r=pdahiya,application-update-reviewers,barret,nalexander
https://hg.mozilla.org/integration/autoland/rev/57f85b3f9562
Move ASRouter into browser/components/asrouter/modules. r=pdahiya,pip-reviewers,fxview-reviewers,sclements
https://hg.mozilla.org/integration/autoland/rev/4da49e6308e4
Move a bunch of ASRouter tests to browser/components/asrouter/tests/unit. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/a65c56354887
Update babel-jsm-to-commonjs to allow for multiple replacements. r=dmose,omc-reviewers
https://hg.mozilla.org/integration/autoland/rev/371e5f07fbc1
Move CFRMessageProvider into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/6143c97e7ca2
Move CFRPageActions into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/d71753ac0eaf
Move RemoteL10n into browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/ea10c2fb4243
Move ModalOverlay into browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/a25d6b5c2fea
Move Button into into browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/46d261387dc1
Move asrouter-utils into browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/6787c36f8e19
Move ImpressionsWrapper and ConditionalWrapper into browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/b98b63b824d3
Move template-utils into browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/24b6d68254f4
Move ASRouter docs into browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/dba58932813d
Move messaging schemas into browser/components/asrouter. r=pdahiya,barret
https://hg.mozilla.org/integration/autoland/rev/2d5a4f170807
Move ASRouter unit test constants to browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/f021f4ea7ffc
Move import-rollouts script into browser/components/asrouter. r=aminomancer
https://hg.mozilla.org/integration/autoland/rev/2959a0470fbe
Move OnboardingMessageProvider to browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/dcb728ae6831
Move PanelTestProvider to browser/components/asrouter/modules. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/e8452223e5a0
Update fxms-schemas for new pathing for schemas and modules. r=barret,ahal
https://hg.mozilla.org/integration/autoland/rev/3494c7da6157
Move some missed tests, and update documentation for new ASRouter pathing. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/aba4b17f7d0d
Update ASRouter coverage expectations for ModalOverlay to match reality. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/7d4b73dbd7ee
Add missing xpcshell.toml file for browser/components/asrouter. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/2e706d67415d
Update codespell.yml and fix linting issues. r=pdahiya
https://hg.mozilla.org/integration/autoland/rev/8f145181f73b
Fix up browser_all_files_referenced.js. r=pdahiya
Regressions: 1877315

https://hg.mozilla.org/mozilla-central/rev/9ee849967df9
https://hg.mozilla.org/mozilla-central/rev/ba04458b277f
https://hg.mozilla.org/mozilla-central/rev/dc7f08dbb91c
https://hg.mozilla.org/mozilla-central/rev/e4493dbebbf3
https://hg.mozilla.org/mozilla-central/rev/b8b710219e6b
https://hg.mozilla.org/mozilla-central/rev/6bad52557d04
https://hg.mozilla.org/mozilla-central/rev/57f85b3f9562
https://hg.mozilla.org/mozilla-central/rev/4da49e6308e4
https://hg.mozilla.org/mozilla-central/rev/a65c56354887
https://hg.mozilla.org/mozilla-central/rev/371e5f07fbc1
https://hg.mozilla.org/mozilla-central/rev/6143c97e7ca2
https://hg.mozilla.org/mozilla-central/rev/d71753ac0eaf
https://hg.mozilla.org/mozilla-central/rev/ea10c2fb4243
https://hg.mozilla.org/mozilla-central/rev/a25d6b5c2fea
https://hg.mozilla.org/mozilla-central/rev/46d261387dc1
https://hg.mozilla.org/mozilla-central/rev/6787c36f8e19
https://hg.mozilla.org/mozilla-central/rev/b98b63b824d3
https://hg.mozilla.org/mozilla-central/rev/24b6d68254f4
https://hg.mozilla.org/mozilla-central/rev/dba58932813d
https://hg.mozilla.org/mozilla-central/rev/2d5a4f170807
https://hg.mozilla.org/mozilla-central/rev/f021f4ea7ffc
https://hg.mozilla.org/mozilla-central/rev/2959a0470fbe
https://hg.mozilla.org/mozilla-central/rev/dcb728ae6831
https://hg.mozilla.org/mozilla-central/rev/e8452223e5a0
https://hg.mozilla.org/mozilla-central/rev/3494c7da6157
https://hg.mozilla.org/mozilla-central/rev/aba4b17f7d0d
https://hg.mozilla.org/mozilla-central/rev/7d4b73dbd7ee
https://hg.mozilla.org/mozilla-central/rev/2e706d67415d
https://hg.mozilla.org/mozilla-central/rev/8f145181f73b

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox124: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Iteration: --- → 124.1 - Jan 22 - Feb 2
Points: --- → 8
Regressions: 1881106
No longer regressions: 1881106
See Also: → 1883450
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: