1883482 - The dismissal acknowledgment is displayed outside the Firefox Suggest section after dismissing a non-top-pick Yelp suggestion positioned at the top of the section

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 125.0a1 - Build ID: 20240301091852
• Firefox Beta 124.0b7 - Build ID: 20240304091753

[Affected Platforms]:

• Windows 10 x64
• macOS 12.6.1
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have the following prefs set with the values to enable the feature:
  browser.search.region = US (connect to a VPN server if outside US)
  browser.urlbar.yelp.featureGate = true
  browser.urlbar.yelp.suggestedIndex = 0
• Have a bookmark/history result that contains a keyword that would trigger a Yelp result (e.g. pet shop).

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Type the “pet shop” keyword in the Address Bar.
3. Click the “Feedback” button from the Yelp suggestion.
4. Click the “Don’t show this” option.
5. Dismiss the suggestion by clicking any of the “Not relevant” or “Not interested” options.
6. Observe how the message is displayed.

[Expected result]:

• The dismissal acknowledgment remains displayed inside the Firefox Suggest section, on the row where the Yelp suggestion was previously displayed.

[Actual result]:

• The dismissal acknowledgment is displayed outside the Firefox Suggest section.

[Notes]:

• This issue is not reproducible when the Yelp suggestion is positioned as the second result, nor the last one (at the bottom of the section).
• Here is a screen recording of the issue.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1883482 - Transfer row labels to dismissal acknowledgment tips in the urlbar.

This makes sure the row label transfers to the dismissal acknowledgment tip, if
the dismissed row has a label.

With that fixed, there's one other cosmetic problem where the tip's top border
is right up against the row label. It doesn't look good. I added some additional
space between the label and border.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9b3f598aa02
Transfer row labels to dismissal acknowledgment tips in the urlbar. r=dao,desktop-theme-reviewers

Comment 3

[Drew Willcoxon :adw]

Comment on attachment 9389292 [details]
Bug 1883482 - Transfer row labels to dismissal acknowledgment tips in the urlbar.

Beta/Release Uplift Approval Request

• User impact if declined: This is a nice-to-have cosmetic fix for the Yelp suggestions experiment that will target 124.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just a cosmetic fix. Has a test.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/c9b3f598aa02

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240308044528) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 12.6.1.

• The dismissal acknowledgment remains displayed inside the Firefox Suggest section, on the row where the Yelp suggestion was previously displayed.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adw, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Carmen Fat [:cfat] - Ecosystem QA]

Marking this report's status as Verified since we tested and verified the issue on the fixed version.