1883544 - Crash in [@ java.lang.IllegalStateException: at android.view.View.startDragAndDrop(View.java)]

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Makoto Kato [:m_kato]]

It seems to depend on drop image. I guess that drop image is 0px.

Crash report: https://crash-stats.mozilla.org/report/index/fe4f42a5-9083-4bb6-94d8-6f2610240305

Java stack trace:

java.lang.IllegalStateException
	at android.view.View.startDragAndDrop(View.java:24023)
	at org.mozilla.gecko.GeckoDragAndDrop$$ExternalSyntheticApiModelOutline0.m(R8$$SyntheticClass:4)
	at org.mozilla.geckoview.GeckoSession.startDragAndDrop(GeckoSession.java:29)
	at org.mozilla.geckoview.GeckoSession$Compositor.startDragAndDrop(GeckoSession.java:3)
	at org.mozilla.gecko.GeckoThread.runUiThreadCallback(Native Method)
	at org.mozilla.gecko.GeckoThread$1.run(GeckoThread.java:4)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6669)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1883544 - Check whether drag image is valid. r=#geckoview-reviewers

I don't know how to reproduce this.

But according to the reason of IllegalStateException, the drop shadow seems
to be negative or 0.

So I would like to add a check whether the image is valid.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/840e1a0d6c22
Check whether drag image is valid. r=geckoview-reviewers,amejiamarmol

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/840e1a0d6c22

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:m_kato, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.