1969901 - Crash in [@ java.lang.IllegalStateException: at android.view.View.startDragAndDrop(View.java)]

Status: NEW

(GeckoView :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Not a new signature, same signature previously fixed in bug 1883544. Many of the crashes are on Android 28, especially if sorted by device type. For Firefox 138.0x, there were 1.1k crashes from 1k installs in the database.

Makoto, could you take a look at this or redirect the request, please?

Crash report: https://crash-stats.mozilla.org/report/index/54a40e67-a98c-4afd-a864-6dfd10250602

MOZ_CRASH Reason:

MOZ_CRASH(JNI exception)

Top 10 frames:

0  libxul.so  MOZ_CrashSequence(void*, int)  mfbt/Assertions.h:253
0  libxul.so  mozilla::jni::Accessor::EndAccess<mozilla::java::GeckoSession::Compositor::St...  widget/android/jni/Accessors.h:61
0  libxul.so  mozilla::jni::Method<mozilla::java::GeckoSession::Compositor::StartDragAndDro...  widget/android/jni/Accessors.h:99
0  libxul.so  mozilla::jni::Method<mozilla::java::GeckoSession::Compositor::StartDragAndDro...  widget/android/jni/Accessors.h:147
1  libxul.so  nsWindow::StartDragAndDrop(mozilla::jni::LocalRef<mozilla::java::sdk::Bitmap>...  widget/android/nsWindow.cpp:2835
1  libxul.so  mozilla::detail::RunnableFunction<nsWindow::StartDragAndDrop(mozilla::jni::Lo...  xpcom/threads/nsThreadUtils.h:548
2  libxul.so  mozilla::RunAndroidUiTasks()  widget/android/AndroidUiThread.cpp:365
3  base.odex  base.odex@0x4f5967
4  base.art (deleted)  base.art (deleted)@0x4f04c2
5  base.art (deleted)  base.art (deleted)@0xd556e

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1969901 - Don't set nagative values for shadow size and shadow touch point. r=#geckoview-reviewers!

If shadow size or touch point is negative, View.startDragAndDrop will
throw an IllegalStateException So we shouldn't pass nagative values

Also, Android 28 doesn't accept zero values for shadow size. So shadow
size has to be at least 1. (Android 29+ adjusts this value to 1 if it
returns 0).

This issue might be occurs when drag image isn't generated. But I
couldn't crate this test case for this situation.