1883721 - Fix extra profiler run for motionmark 1.3 benchmark

Status: RESOLVED FIXED

(Testing :: Performance, defect, P2)

Description

[Kash Shampur [:kshampur] ⌚EST]

Currently the --extra-profiler-run is not working properly and no profiles are gathered for mm 1.3
example error

[task 2024-03-01T02:53:01.247Z] 02:53:01     INFO -  raptor-browsertime Info: Custom profiler start!
[task 2024-03-01T02:53:01.267Z] 02:53:01     INFO -  raptor-browsertime Info: Start GeckoProfiler with features: ["stackwalk","js","cpu","java","processcpu"] and threads: ["GeckoMain","Compositor","Renderer","SwComposite","RenderBackend","SceneBuilder","WrWorker","CanvasWorkers","TextureUpdate"]
[task 2024-03-01T02:53:04.283Z] 02:53:04     INFO -  raptor-browsertime Info: Testing url http://127.0.0.1:49237/MotionMark/developer.html?warmup-length=2000&warmup-frame-count=30&first-frame-minimum-length=0&test-interval=30&display=minimal&tiles=big&controller=ramp&system-frame-rate=60&frame-rate=60&time-measurement=performance iteration 1
[task 2024-03-01T02:53:10.392Z] 02:53:10     INFO -  raptor-browsertime Info: CPU / Power usage: 2351
[task 2024-03-01T02:53:10.486Z] 02:53:10     INFO -  raptor-browsertime Info: Browsertime failed to run on extra profiler run
[task 2024-03-01T02:53:10.487Z] 02:53:10     INFO -  raptor-browsertime Info: Browsertime for extra profiler run failure: Could not single click on element with selector #suites > ul > li:nth-child(undefined) > label > input[type="checkbox"]

For some reason the css selector is not able to be selected. This is reproducible locally as well.

Comment 1

[Kash Shampur [:kshampur] ⌚EST]

:canova pointed out that this modify command was not happening in the extra profiler part

Comment 2

[Nazım Can Altınova [:canova]]

Attachment: Bug 1883721 - Move the support_class modify_class call inside the _compose_cmd r?#perftest,kshampur

Previously modify_class call was right outside of the _compose_cmd call.
Because of that this wasn't shared between the main and extra-profiler runs.
After moving the modify_class call inside of this function, it's now shared
between these two runs since we call this method explicitly for both of these
runs.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b201143795ca
Move the support_class modify_class call inside the _compose_cmd r=kshampur,perftest-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b201143795ca