1883739 - Add disk size measurements for all general user preference and user permission stores

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

There's some shared infrastructure here with bug 1883642 (for the metrics.yaml file, for setting up the private method in BackupService that does measurement, and for test infrastructure).

This is the set of things to measure the size of:

• prefs.js
• xulstore.json
• permissions.sqlite
• content-prefs.sqlite
• containers.json
• handlers.json
• search.json.mozlz4
• user.js
• chrome/userChrome.css
• chrome/userContent.css

Similar to bug 1883655 and bug 1883642, this is a matter of adding some quantity probes, and then stat'ing these files, converting the measurement to kilobytes, and recording them to the Glean probes. We'll need a data-review and tests. Don't forget about ./mach data-review to help you out!

Comment 1

[kpatenio]

Attachment: Bug 1883739 - Add disk size measurements for all general user preference and user permission stores. r=#backup-reviewers!

Comment 2

[kpatenio]

Attachment: Data collection request

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9392349 [details]
Data collection request

data-review+

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, mconley will monitor.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5. Is the data collection request for default-on or default-off?

Default on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4816ddcf03ba
Add disk size measurements for all general user preference and user permission stores. r=backup-reviewers,mconley

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 4816ddcf03ba (Bug 1883739) for causing failures in test_measurements.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=windows%2C11%2Cx64%2C22h2%2Cwebrender%2Copt%2Cxpcshell%2Ctests%2Ctest-windows11-64-2009-qr%2Fopt-xpcshell%2Cx2&revision=4816ddcf03ba85987ae2877b961ec314a5ed575e
Another relevant range: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=a960e8bc060150359968f7771651f430d3df04df&searchStr=windows%2C11%2Cx64%2C22h2%2Cwebrender%2Copt%2Cxpcshell%2Ctests%2Ctest-windows11-64-2009-qr%2Fopt-xpcshell%2Cx2&tochange=7e65c2e3fa5893e80c6f6f8ef4deef5861f82edc

Log: https://treeherder.mozilla.org/logviewer?job_id=451572572&repo=autoland&lineNumber=3647

Backout: https://hg.mozilla.org/integration/autoland/rev/1fc14e10e349b1c81d8b36fae2872660943a36fe

Comment 6

[kpatenio]

Attachment: WIP: Bug 1883739 - Add disk size measurements for all general user preference and user permission stores. r=#backup-reviewers!

Comment 7

[Phabricator Automation]

Comment on attachment 9392861 [details]
WIP: Bug 1883739 - Add disk size measurements for all general user preference and user permission stores. r=#backup-reviewers!

Revision D205503 was moved to bug 1883747. Setting attachment 9392861 [details] to obsolete.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30e247121546
Add disk size measurements for all general user preference and user permission stores. r=backup-reviewers,mconley

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/30e247121546