1883740 - Add disk size measurements for cookies, form history and sessions

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

There's some shared infrastructure here with bug 1883642 (for the metrics.yaml file, for setting up the private method in BackupService that does measurement, and for test infrastructure).

This is the set of things to measure the size of:

• cookies.sqlite
• formhistory.sqlite
• sessionstore.jsonlz4
• the sessionstore-backups/ directory's contents (a sum of the contents is fine)

Similar to bug 1883655 and bug 1883642, this is a matter of adding some quantity probes, and then stat'ing these files, converting the measurement to kilobytes, and recording them to the Glean probes. We'll need a data-review and tests. Don't forget about ./mach data-review to help you out!

Comment 1

[:Gijs (he/him)]

This is showing up in my triage queue; I assume P1 is accurate because this is assigned but please feel free to adjust.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Note: we'll want a separate BackupResource class for Cookies, so that we can make it easy to not include that in the backup if encryption is not enabled.

Comment 3

[Fred Chasen [:fchasen]]

Attachment: Bug 1883740 - Add disk size measurements for cookies, form history and sessions. data-review=jhirsch r=#backup-reviewers!

Comment 4

[Fred Chasen [:fchasen]]

Attachment: Data collection request

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 9392573 [details]
Data collection request

data-review+

I'd suggest mentioning specifics of how we round off or fuzz the data in the description of the measurement in the probe definitions (guessing it will be rounded to the nearest 10 kB, as done for other bugs in this set).

---

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, the usual Firefox data docs.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the data collection opt-out in Firefox preferences.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, mconley will monitor.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5. Is the data collection request for default-on or default-off?

Default on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does the data collection use a third-party collection tool?

No.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cbb780fbe07
Add disk size measurements for cookies, form history and sessions. data-review=jhirsch r=backup-reviewers,mconley

Comment 7

[Cristian Tuns]

Backed out for causing xpcshell failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/backup/tests/xpcshell/test_measurements.js | xpcshell return code: 0

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b2ac43d7719
Add disk size measurements for cookies, form history and sessions. data-review=jhirsch r=backup-reviewers,mconley

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8b2ac43d7719