1883765 - [RTL] Screenshot UI is displayed as LTR

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P1)

Description

[Itiel]

Attachment: Screenshot

See attached, the senctence is in reverse (the dot in the wrong spot, and the ESC makes the text to appear in the wrong order).
This is being forced to LTR by this:
https://searchfox.org/mozilla-central/rev/6b0b8c1003504e302e243c300355ef4d61e24909/layout/style/res/ua.css#454

Comment 1

[Itiel]

Attachment: Screenshot 2

Also the buttons appear from left to right (the icon should appear on the right)

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1883765 - Screenshots ui should follow page direction. r=itiel

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1789727

Comment 4

[Donal Meehan [:dmeehan]]

:nikla just a reminder that 125 goes to beta next week.
The patch is pending some revisions, if this can be updated and landed in central this week?

Comment 5

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1789727

Comment 6

[Sam Foster [:sfoster] (he/him)]

(In reply to Donal Meehan [:dmeehan] from comment #4)

:nikla just a reminder that 125 goes to beta next week.
The patch is pending some revisions, if this can be updated and landed in central this week?

This whole feature is behind a pref that is only default on in Nightly. However, it wouldn't hurt to uplift a fix for beta and release users that have manually flipped the pref.

Comment 7

[Sam Foster [:sfoster] (he/him)]

(In reply to Itiel from comment #0)

This is being forced to LTR by this:
https://searchfox.org/mozilla-central/rev/6b0b8c1003504e302e243c300355ef4d61e24909/layout/style/res/ua.css#454

I think I would expect this overlay UI's direction to follow that of the browser chrome, not whatever document the anonymous content is hosted in. It would be weird to have it LTR on one page, and RTL on another. Does that sound right :Itiel?

In that case I guess we need to pass the direction down from the parent and explicitly set the direction property from JS when we create the overlay.

Comment 8

[Itiel]

(In reply to Sam Foster [:sfoster] (he/him) from comment #7)

(In reply to Itiel from comment #0)

This is being forced to LTR by this:
https://searchfox.org/mozilla-central/rev/6b0b8c1003504e302e243c300355ef4d61e24909/layout/style/res/ua.css#454

I think I would expect this overlay UI's direction to follow that of the browser chrome, not whatever document the anonymous content is hosted in. It would be weird to have it LTR on one page, and RTL on another. Does that sound right :Itiel?

Correct.

Comment 9

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1883765 - Screenshots direction should match browser direction. r=sfoster,itiel

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4fa0d22768b
Screenshots direction should match browser direction. r=sfoster,Itiel

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d4fa0d22768b

Comment 12

[Simona Badau, Desktop QA, PTO 14-27aug]

Attachment: Screenshot on Nightly 126

I can confirm that in the latest Nightly 126.0a1, the dot is now in the right position when making a mouse/click selection and the button's icon appears on the right side.

However, I've noticed a couple of things that I'm not sure are intended or not:

1. The buttons are still displayed on the left side of the screen selection and not on the right.
2. The "x" from the pixels counter is no longer in the middle as it is in Comment 1 (please see the screenshot).

Niklas, are these behaviors intended?

Comment 13

[Itiel]

(In reply to Simona Badau, Desktop QA from comment #12)

Created attachment 9395554 [details]
Screenshot on Nightly 126

I can confirm that in the latest Nightly 126.0a1, the dot is now in the right position when making a mouse/click selection and the button's icon appears on the right side.

However, I've noticed a couple of things that I'm not sure are intended or not:

1. The buttons are still displayed on the left side of the screen selection and not on the right.
2. The "x" from the pixels counter is no longer in the middle as it is in Comment 1 (please see the screenshot).

Niklas, are these behaviors intended?

You're absolutely correct about #2, can you file a bug on this and needinfo me? Should be an easy fix, just force LTR for the text span.
I think you're right also about #1, the code for this should be somewhere around https://searchfox.org/mozilla-central/rev/294e1fbdcc9ca0c328c372392e03bb49df4ee77e/browser/components/screenshots/ScreenshotsOverlayChild.sys.mjs#1449,1452

Niklas, does that sound about right? ^

Comment 14

[Simona Badau, Desktop QA, PTO 14-27aug]

Verified as fixed using the latest Nightly 127.0a1 and Firefox 126.0b5 (having 'screenshots.browser.component.enabled' set to 'true') on macOS 13, Ubuntu 22.04 and Windows 10.x64 - the issues mentioned in the Description and Comment 1 are no longer reproducible.

Also, I logged Bug 1893460 to cover the left issue from Comment 12.