1883784 - [wmfme] optimize the capabilites query time for MFCDM

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

This bug is used to optimize the capabilities query time for MFCDM

Comment 1

[Alastor Wu [:alwu]]

Attachment: WIP: Bug 1883784 - run the initialization of IPC actor and reading metadata parallelly in order to reduce the preparation time.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1883784 - part1 : reuse media engine factory to avoid unnecessary creation.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1883784 - part2 : only perform HDCP check if necessary.

"The hdcp query (item 4) has a computationally expensive first
invocation cost". See [1].

[1] https://learn.microsoft.com/en-us/windows/win32/api/mfmediaengine/nf-mfmediaengine-imfextendeddrmtypesupport-istypesupportedex

Depends on D205273

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1883784 - part3 : no need to check audio for hardware decryption.

Depends on D205274

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1883784 - part4 : no need to ask cenc again because it's the default value.

'If value is unspecified, default value of "cenc" is used.' That means
those supported video codecs we have now already support 'cenc', so we
don't need to query 'cenc' again.

See [1].

[1] https://learn.microsoft.com/en-us/windows/win32/api/mfmediaengine/nf-mfmediaengine-imfextendeddrmtypesupport-istypesupportedex

Depends on D205275

Comment 6

[Alastor Wu [:alwu]]

Attachment: Bug 1883784 - part5 : add a new CapabilitesFlag for ClearLead check.

Depends on D205276

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5746d7c29ac
part1 : reuse media engine factory to avoid unnecessary creation. r=jolin
https://hg.mozilla.org/integration/autoland/rev/b5794c5f581e
part2 : only perform HDCP check if necessary. r=jolin
https://hg.mozilla.org/integration/autoland/rev/d7ec6f631e8d
part3 : no need to check audio for hardware decryption. r=jolin
https://hg.mozilla.org/integration/autoland/rev/6a72ba930bd7
part4 : no need to ask cenc again because it's the default value. r=jolin
https://hg.mozilla.org/integration/autoland/rev/583a6e5b34d4
part5 : add a new CapabilitesFlag for ClearLead check. r=jolin

Comment 8

[pstanciu]

Backed out for causing (part of commit message)

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e112d7db9cbb
part1 : reuse media engine factory to avoid unnecessary creation. r=jolin
https://hg.mozilla.org/integration/autoland/rev/8f1acf9322b9
part2 : only perform HDCP check if necessary. r=jolin
https://hg.mozilla.org/integration/autoland/rev/c569adae327d
part3 : no need to check audio for hardware decryption. r=jolin
https://hg.mozilla.org/integration/autoland/rev/3974723c71be
part4 : no need to ask cenc again because it's the default value. r=jolin
https://hg.mozilla.org/integration/autoland/rev/396b76ded255
part5 : add a new CapabilitesFlag for ClearLead check. r=jolin

Comment 10

[Cristian Tuns]

Backed out for causing bc failures in EnumSerializer.h

• Backout link
• Push with failures
• Failure Log
• Failure line: Assertion failure: EnumValidator::IsLegalValue( static_cast<std::underlying_type_t<paramType>>(aValue)), at /builds/worker/workspace/obj-build/dist/include/ipc/EnumSerializer.h:61

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1080811a9d3d
part1 : reuse media engine factory to avoid unnecessary creation. r=jolin
https://hg.mozilla.org/integration/autoland/rev/a6fbdb6bdac5
part2 : only perform HDCP check if necessary. r=jolin
https://hg.mozilla.org/integration/autoland/rev/597f18d7fd81
part3 : no need to check audio for hardware decryption. r=jolin
https://hg.mozilla.org/integration/autoland/rev/08a0c66ba15d
part4 : no need to ask cenc again because it's the default value. r=jolin
https://hg.mozilla.org/integration/autoland/rev/64c75b6d3d32
part5 : add a new CapabilitesFlag for ClearLead check. r=jolin

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1080811a9d3d
https://hg.mozilla.org/mozilla-central/rev/a6fbdb6bdac5
https://hg.mozilla.org/mozilla-central/rev/597f18d7fd81
https://hg.mozilla.org/mozilla-central/rev/08a0c66ba15d
https://hg.mozilla.org/mozilla-central/rev/64c75b6d3d32