1883857 - object metric: Add JOG support

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P2)

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: WIP: Bug 1883857 - Enable schema-verification for runtime object metrics r?chutten!

Now values set on runtime object metrics are checked against the provided schema.
We use jtd - JSON type definitions - a schema definition similar to
json-schema, but much smaller in scope (RFC 8927).
We pull in the (official) jtd crate for that (it's rather small, ~1000 lines of code).

The schema is dumped into the jogfile and provided on instantiation in
the JOG code.
If that schema is defined at runtime values are checked.
That means there's one more runtime check, though that should be rather
cheap (and in code we can separate that case in the match).

This now makes test_Glean.js pass.
Not done yet: Check which other object metric tests should be
re-enabled.

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1883857 - Enable object metrics in artifact builds by using a dynamic object r?chutten!

This makes it possible to instantiate object metrics using JOG.
This does NOT check values against the provided schema.

Thus while this enables object metrics, they behave slightly different
than the otherwise builtin ones:
set and get works as expected from JavaScript.
However on set nothing is checked. You can set arbitrary values and
they will be recorded and returned.
Any error checking will fail.
With this change test_Glean.js fails, because it not only checks the
positive case (setting an object works), but also the negative cases
(checking that an error is recorded when invalid objects are set).

Comment 3

[Phabricator Automation]

Comment on attachment 9465116 [details]
WIP: Bug 1883857 - Enable schema-verification for runtime object metrics r?chutten!

Revision D237547 was moved to bug 1947194. Setting attachment 9465116 [details] to obsolete.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8714b406da63
Enable object metrics in artifact builds by using a dynamic object r=chutten

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8714b406da63

Comment 7

[Intermittent Failures Robot]

Summary

18 failures in 5022 pushes (0.004 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1
• try: 15
• mozilla-release: 1
• mozilla-esr128: 1

Platform and build breakdown:

• linux1804-64-devedition-qr: 1
  • opt: 1
• linux1804-64-qr: 11
  • opt: 8
  • debug: 3
• windows11-32-2009-qr: 2
  • opt: 2
• windows11-32-24h2: 2
  • debug: 2
• windows11-64-2009-qr: 1
  • debug: 1
• windows11-64-24h2: 1
  • opt: 1

Table

	a11y-checks-swr	msix	no_variant	spi-nw	swr
linux1804-64-devedition-qr--/opt					1
linux1804-64-qr--/opt	1			3	4
linux1804-64-qr--/debug				1	2
windows11-32-2009-qr--/opt			2
windows11-32-24h2--/debug			2
windows11-64-2009-qr--/debug			1
windows11-64-24h2--/opt		1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1883857&startday=2025-02-10&endday=2025-02-16&tree=all