1884041 - fix create-a-bug links to work with java_exception

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Currently, for Java crashes, the create-a-bug link template depends on the java_stack_trace field in the processed crash which is derived from the JavaStackTrace annotation.

https://github.com/mozilla-services/socorro/blob/main/webapp/crashstats/crashstats/jinja2/crashstats/bug_comment.txt

We ultimately want to phase out JavaStackTrace in favor of JavaException.

We need to fix the create-a-bug links to work with java_exception field in the processed crash.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

We may want to redo how the create-a-bug link works. Currently it's built using a Jinja2 template which is finicky about whitespace and incredibly difficult to maintain and change.

Further, Suhaib expressed interest in having a more exportable bit of code for generating the stacks for use in bug reports. They want to re-use it for automated bug creation.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Example Fenix crash report that has JavaException but no JavaStackTrace:

• bp-125840f3-a9b1-4307-b605-a04da0240327

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I refactored the code that creates the links in bug #1849266, so I can work on this now and it should be pretty straight forward to do a first pass.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/socorro] bug-1884041: support java_exception in crash_report_to_description (#6566)

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/socorro]: bug-1884041: support java_exception in crash_report_to_description (#6566) in 7d492a0.

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

This deployed to production just now in bug #1890341.

Here's an example. Crash report bp-eb6f852b-4656-4cf5-8350-fd91a0240408 which has a JavaException annotation, but no JavaStackTrace annotation. Before these changes, the comment would be:

Crash report: https://crash-stats.mozilla.org/report/index/eb6f852b-4656-4cf5-8350-fd91a0240408

Now the comment is:

Crash report: https://crash-stats.mozilla.org/report/index/eb6f852b-4656-4cf5-8350-fd91a0240408

Top 10 frames:

0  android.database.sqlite.SQLiteConnection  nativePrepareStatement  SQLiteConnection.java:-2
1  android.database.sqlite.SQLiteConnection  acquirePreparedStatement  SQLiteConnection.java:939
2  android.database.sqlite.SQLiteConnection  executeForString  SQLiteConnection.java:684
3  android.database.sqlite.SQLiteConnection  setJournalMode  SQLiteConnection.java:369
4  android.database.sqlite.SQLiteConnection  setWalModeFromConfiguration  SQLiteConnection.java:299
5  android.database.sqlite.SQLiteConnection  open  SQLiteConnection.java:218
6  android.database.sqlite.SQLiteConnection  open  SQLiteConnection.java:196
7  android.database.sqlite.SQLiteConnectionPool  openConnectionLocked  SQLiteConnectionPool.java:503
8  android.database.sqlite.SQLiteConnectionPool  open  SQLiteConnectionPool.java:204
9  android.database.sqlite.SQLiteConnectionPool  open  SQLiteConnectionPool.java:196