Closed Bug 1884067 Opened 11 months ago Closed 11 months ago

Update PDF.js to new version 6bb6ce6a5d133c5aa318e2fff9d1df5326a1ea96 from 2024-03-06 13:39:58

Categories

(Firefox :: PDF Viewer, enhancement)

Product:
Firefox
Component:
PDF Viewer
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1883901
Tracking Flags:
Tracking Status
firefox125 --- affected

People

(Reporter: update-bot, Assigned: update-bot)

Details

(Whiteboard: [3pl-filed][task_id: cC3UVY7oTdWlUzOGXdYs_A])

Attachments

(1 file)

Bug 1884067 - Update PDF.js to 6bb6ce6a5d133c5aa318e2fff9d1df5326a1ea96
48 bytes, text/x-phabricator-request
Details | Review

This update covers 10 commits. Here are the overall diff statistics, and then the commit information.

toolkit/components/pdfjs/content/build/pdf.mjs | 66 +++-
toolkit/components/pdfjs/content/build/pdf.scripting.mjs | 4 +-
toolkit/components/pdfjs/content/build/pdf.worker.mjs | 15 +-
toolkit/components/pdfjs/content/web/images/gv-toolbarButton-openinapp.svg | 11 -
toolkit/components/pdfjs/content/web/viewer-geckoview.css | 5 -
toolkit/components/pdfjs/content/web/viewer-geckoview.html | 3 -
toolkit/components/pdfjs/content/web/viewer-geckoview.mjs | 129 +++++----
toolkit/components/pdfjs/content/web/viewer.css | 19 +-
toolkit/components/pdfjs/content/web/viewer.mjs | 122 +++++---
toolkit/components/pdfjs/moz.yaml | 4 +-
toolkit/locales/en-US/toolkit/pdfviewer/viewer.ftl | 8 -
11 files changed, 216 insertions(+), 170 deletions(-)

6d0835dc5246c3ac64ef7cc5dbdfbafc173fc140 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/6d0835dc5246c3ac64ef7cc5dbdfbafc173fc140
Authored: 2024-03-04 16:47:58 +0100
Committed: 2024-03-06 14:21:57 +0100

In the m-c automation, give the possibility to remove window listeners when a test ended

The goal is to avoid to have some exceptions in the logs when a test finished.

Files Modified:

  • web/app.js

4e1b96c781eae495737bf966dbf06653b24964f1 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/4e1b96c781eae495737bf966dbf06653b24964f1
Authored: 2024-03-05 16:20:16 +0100
Committed: 2024-03-05 19:04:58 +0100

[Annotations] Widget annotations must be in front of the other ones (bug 1883609)

Files Added:

Files Modified:

  • src/core/annotation.js
  • src/core/document.js
  • test/integration/annotation_spec.mjs
  • test/pdfs/.gitignore

bd5875d066da2bc6754c99a96872c3dff7e01f07 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/bd5875d066da2bc6754c99a96872c3dff7e01f07
Authored: 2024-03-05 15:28:32 +0100
Committed: 2024-03-05 16:47:07 +0100

[Editor] Let a free highlight be clipped when its bounding box exceeds the page limits (bug 1883632)

Files Modified:

  • src/display/editor/editor.js
  • src/display/editor/highlight.js
  • test/integration/highlight_editor_spec.mjs

ba3e55958384c18657a824d57b1e1bfd61e54be8 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/ba3e55958384c18657a824d57b1e1bfd61e54be8
Authored: 2024-03-04 20:17:47 +0100
Committed: 2024-03-04 20:17:47 +0100

Don't stringify data for telemetry

Files Modified:

  • web/firefoxcom.js

3cb58f84a202612a8db374b8544e3c9dccb3d804 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/3cb58f84a202612a8db374b8544e3c9dccb3d804
Authored: 2024-03-04 19:32:12 +0100
Committed: 2024-03-04 19:32:12 +0100

[GeckoView] Remove the open-in-app button (bug 1832519)

Files Deleted:

  • web/images/gv-toolbarButton-openinapp.svg

Files Modified:

  • l10n/en-US/viewer.ftl
  • web/app.js
  • web/toolbar-geckoview.js
  • web/viewer-geckoview.css
  • web/viewer-geckoview.html
  • web/viewer-geckoview.js

ecb4262b13b53c3877164c1db421012d9881ab57 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/ecb4262b13b53c3877164c1db421012d9881ab57
Authored: 2024-03-04 16:58:50 +0100
Committed: 2024-03-04 16:58:50 +0100

[Editor] Set the creation method for free highlights to 'main_toolbar' (bug 1883394)

Files Modified:

  • src/display/editor/highlight.js

1859412507bd6cd9b59b584dc81df6960304ad41 by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/1859412507bd6cd9b59b584dc81df6960304ad41
Authored: 2024-03-04 16:32:09 +0100
Committed: 2024-03-04 16:32:09 +0100

[Editor] Unselect highlight editor when pressing Escape when the focus is on the color picker without a dropdown menu

Files Modified:

  • src/display/editor/color_picker.js
  • test/integration/highlight_editor_spec.mjs

d096dc79b254fd63276b2bfd7e4187e8c3cf811c by Calixte Denizet

https://github.com/mozilla/pdf.js/commit/d096dc79b254fd63276b2bfd7e4187e8c3cf811c
Authored: 2024-03-04 10:18:24 +0100
Committed: 2024-03-04 10:18:24 +0100

[Editor] Use a null instead of an empty stats object when sending the telemetry

Files Modified:

  • src/display/annotation_storage.js

e781b553cb4da296be492ef540bb41563a08cfeb by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/e781b553cb4da296be492ef540bb41563a08cfeb
Authored: 2024-03-01 16:14:07 +0100
Committed: 2024-03-01 16:18:39 +0100

[Editor] Reduce a bit of CSS duplication for the highlight-thickness "indicators"

Files Modified:

  • web/annotation_editor_layer_builder.css

c7e7122e25208f9e039bb7cb1d9d5c3640d9141d by Jonas Jenwald

https://github.com/mozilla/pdf.js/commit/c7e7122e25208f9e039bb7cb1d9d5c3640d9141d
Authored: 2024-03-01 16:05:27 +0100
Committed: 2024-03-01 16:18:31 +0100

[Editor] Indicate if the highlight-thickness slider is disabled

The fact that the highlight-thickness can only be changed in "free" mode isn't really obvious visually in the toolbar, so attempt to provide at least some indication of the disabled-state by "dimming" the slider.

Files Modified:

  • web/annotation_editor_layer_builder.css

I've submitted a try run for this commit: https://treeherder.mozilla.org/jobs?repo=try&revision=c257dc95e78e6b929f72166ae79a0a1aa1ebaf7f

Assignee: nobody → update-bot
Status: NEW → ASSIGNED
No longer blocks: pdfjs-updates
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Duplicate of bug: 1883901
Resolution: --- → DUPLICATE

The try push is done, we found jobs with unclassified failures.

Known Issues (From Taskcluster):

  • test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (VVEpZBqJS0Kjsiic-YWZNA) - new failure not classified

Needs Investigation (From Push Health):

  • toolkit/components/pdfjs/test/browser_pdfjs_download_button.js
    • 1 of 1 failed on the same (retriggered) task
      - test-windows11-32-2009-qr/debug-mochitest-browser-chrome-1 (VVEpZBqJS0Kjsiic-YWZNA)

Needs Investigation (Other Failed Jobs):

  • test-windows11-64-2009-qr/opt-test-verify
    • 1 of 1 failed on the same (retriggered) task (FXO4lfBsT9-YQ-sDVcXEPg)
  • test-windows11-64-2009-qr/debug-test-verify
    • 1 of 1 failed on the same (retriggered) task (BaBkaqZVTs-WgZQ4woJEXg)
  • test-windows11-32-2009-qr/opt-test-verify
    • 1 of 1 failed on the same (retriggered) task (dnw3JYF1RxWQylHj83qOXg)
  • test-windows11-32-2009-qr/debug-test-verify
    • 1 of 1 failed on the same (retriggered) task (PwDgmPkWR26Yniwsh_0G1g)

These failures could mean that the library update changed something and caused
tests to fail. You'll need to review them yourself and decide where to go from here.

In either event, I have done all I can and you will need to take it from here. If you
don't want to land my patch, you can replicate it locally for editing with
./mach vendor toolkit/components/pdfjs/moz.yaml

When reviewing, please note that this is external code, which needs a full and
careful inspection - not a rubberstamp.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: