1884090 - Add support for "HTTP flag" in WebDriver Session

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

To differentiate between WebDriver classic (HTTP) and WebDriver BiDi the classic spec got a HTTP flag added:
https://w3c.github.io/webdriver/#dfn-http-flag

This flag would be needed for Multiple Session support (bug 1862018).

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It looks like that I missed to update the whiteboard for this bug given that this bug is listed as required for M11 and after implementing bug 1884650 I would agree to have it in this milestone.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Try push for the soon upcoming patches:
https://treeherder.mozilla.org/jobs?repo=try&revision=0abad9524ceaa2934e0f0cb163c5ccce57864225

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1884090 - [remote] Add support for "HTTP flag" in WebDriver Session.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f5bdb253c2e
[remote] Add support for "HTTP flag" in WebDriver Session. r=webdriver-reviewers,jdescottes

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing mochitets failures in browser_Troubleshoot.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/modules/tests/browser/browser_Troubleshoot.js | Schema mismatch, Error: Validation error: Object is not of the expected type: object=["[GFX1-]: glxtest: ManageChildProcess failed\n","[GFX1-]: No GPUs detected via PCI\n"], schema={"type":"object","properties":{"key":{"required":true,"type":"string"},"args":{"required":false,"type":"object"}}} -

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This is a failure when getting the GfxInfo. A change that I've made is the following:

-        "moz:headless",
-        Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo).isHeadless,
[..]
+ ChromeUtils.defineLazyGetter(lazy, "isHeadless", () => {
+    return Cc["@mozilla.org/gfx/info;1"].createInstance(Ci.nsIGfxInfo).isHeadless;
+. });

So I've accidentally replaced the call to getService() with getInstance(), which clearly should fail. Still interesting that this is still working fine on other platforms than Linux and even Linux opt. I'll fix and push again.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/374f26d432ea
[remote] Add support for "HTTP flag" in WebDriver Session. r=webdriver-reviewers,jdescottes

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/374f26d432ea