1824220 - Add support for "beforeunload" simple prompts

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

With bug 1824197 we will get support for simple dialogs like alert, prompt, and confirm.

But we also have to support beforeunload prompts. Before we can add support for those prompts we will have to fix bug 1693857 for Marionette which currently completely disabled these type of prompts.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Actually this would also require us to add support for both the browsingContext.userPromptOpened and browsingContext.userPromptClosed events as well. So lets wait for their initial implementation first.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1824220 - [webdriver-bidi] Add support for "beforeunload" prompts.

Depends on D198682

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1824220 - [wdspec] Add BiDi tests for beforeunload prompts.

Depends on D199471

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

This bug is currently still blocked.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

We are going to ignore the Android TestRunner support for now, and we can add that later.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

Attachment: Bug 1824220 - [geckoview] Return promptType in details for DOMModalDialogClosed event.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/989f4619897b
[geckoview] Return promptType in details for DOMModalDialogClosed event. r=ohall,geckoview-reviewers
https://hg.mozilla.org/integration/autoland/rev/6393df0d4ce1
[webdriver-bidi] Add support for "beforeunload" prompts. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/6c4ce197ba26
[wdspec] Add BiDi tests for beforeunload prompts. r=webdriver-reviewers,jdescottes

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46808 for changes under testing/web-platform/tests

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/989f4619897b
https://hg.mozilla.org/mozilla-central/rev/6393df0d4ce1
https://hg.mozilla.org/mozilla-central/rev/6c4ce197ba26

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2] (away 10/03 - 10/13)]

I've opened https://github.com/puppeteer/puppeteer/pull/12616 to update the test expectations.