1884221 - Improve telemetry for out-of-process file-picker failures

Status: RESOLVED FIXED

(Core :: Widget: Win32, enhancement)

Description

[Ray Kraesig [:rkraesig]]

The telemetry ping for out-of-process file-picker failure when the utility process failed to launch should include information sufficient to indicate a) what failed, and b) why it was reported to have done so.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: bug 1884221, data-review request for.txt

Data steward selected randomly via probably-fair die (Math.floor(Math.random()*14)) from the list at https://wiki.mozilla.org/Data_Collection.

Comment 2

[Daniela Arcese [:daniela]]

Attachment: data-review-form

Comment 3

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1884221 - [1/2] Extend error propagation slightly r?#win-reviewers

Extend LaunchError propagation such that nsFilePicker::Open can
access the error.

This is of little relevance to this patchset -- it's merely been taken
from the in-work implementation of bug 1884426 to minimize rebase-
induced manual code shuffling.

No functional changes.

Comment 4

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1884221 - [1/1] Add fallback_v2 telemetry r?#win-reviewers

Add new telemetry for the file-dialog picker which should more precisely
pinpoint the initial cause of failures.

Data-review approval: https://bugzilla.mozilla.org/show_bug.cgi?id=1884221#c2

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07f312147f99
[1/1] Add fallback_v2 telemetry  r=win-reviewers,gstoll
https://hg.mozilla.org/integration/autoland/rev/050390d09a8f
1895375: apply code formatting via Lando

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/07f312147f99
https://hg.mozilla.org/mozilla-central/rev/050390d09a8f