1895375 - Improve error propagation for out-of-process file-picker failures, round 2

Status: RESOLVED FIXED

(Core :: Widget: Win32, task)

Description

[Ray Kraesig [:rkraesig]]

Error-site data is collected by the utility process launcher and propagated internally, but is not generally provided to its clients.

However, error-site data is exactly what's desired by file-picker telemetry to determine the underlying cause of launch-failure errors, so let's go ahead and do that.

Comment 1

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1895375 - [1/4] Adjust types associated with ipc::LaunchError r?#ipc-reviewers!,#win-reviewers!

As the intended use for LaunchError::mFunction is telemetry, avoid the
possibility of accidental exfiltration of PII by requiring that
LaunchError be constructed from StaticString.

No functional changes.

Comment 2

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1895375 - [2/4] Adjust filedialog::Error to use StaticString r?#win-reviewers!

As with the previous commit, avoid the possibility of accidental
exfiltration of PII by requiring that filedialog::Error be constructed
from StaticString.

No functional changes.

Comment 3

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1895375 - [3/4] Allow creating fd::Errors from ipc::LaunchErrors r?#win-reviewers!

Since the location field of a LaunchError is a static, telemetry-safe
string, allow creating an fd::Error therefrom.

(Such an Error won't be serializable over IPDL, but that's fine -- if we
have a LaunchError, we must be in the main process and so have no need
to worry about serializing it.)

Comment 4

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1895375 - [4/4] Propagate ipc::LaunchErrors to callers r?#ipc-reviewers,#win-reviewers

• Adjust GeckoChildProcessHost to return ipc::LaunchErrors to its
  clients.

• Adjust UtilityProcessHost to propagate ipc::LaunchErrors for
  its clients, or to create new ones where none previously existed.

• Adjust the various clients of the above to to handle the additional
  information -- mostly by adding the additional failure-location data
  to log messages.

In particular, filedialog::Error objects should now contain -- and report
to telemetry without further adjustment -- the actual error code from
ipc::LaunchErrors.

(Reporting the original failure location as well will occur in bug
1884221.)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89eb91c37298
[1/4] Adjust types associated with ipc::LaunchError  r=ipc-reviewers,win-reviewers,gstoll,nika
https://hg.mozilla.org/integration/autoland/rev/3f5ca5edd343
[2/4] Adjust filedialog::Error to use StaticString  r=win-reviewers,gstoll
https://hg.mozilla.org/integration/autoland/rev/632b10bbca9c
[3/4] Allow creating fd::Errors from ipc::LaunchErrors  r=win-reviewers,gstoll
https://hg.mozilla.org/integration/autoland/rev/b4086527c442
[4/4] Propagate ipc::LaunchErrors to callers  r=ipc-reviewers,nika

Comment 6

[Ray Kraesig [:rkraesig]]

Attachment: Bug 1895375 - Followup: fix non-unified builds r?CosminS

Patch [3/4] in the previous patchset removed an #include, breaking
non-unified builds. Replace it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94093b6cb25b
Followup: fix non-unified builds. a=bustage-fix CLOSED TREE

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8bc6fa2ba2e8
Followup: fix non-unified builds. a=bustage-fix CLOSED TREE

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/89eb91c37298
https://hg.mozilla.org/mozilla-central/rev/3f5ca5edd343
https://hg.mozilla.org/mozilla-central/rev/632b10bbca9c
https://hg.mozilla.org/mozilla-central/rev/b4086527c442
https://hg.mozilla.org/mozilla-central/rev/8bc6fa2ba2e8

Comment 10

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/94093b6cb25b