Open Bug 1884318 Opened 2 years ago Updated 1 year ago

Speedup mach's preprocessor starting time

Categories

(Firefox Build System :: General, task)

Product:
Firefox Build System
Component:
General
Type:
task

Tracking

(Not tracked)

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium!
48 bytes, text/x-phabricator-request
Details | Review

preprocessor.py is run several times for tasks that block the execution of webidl.py, which is a bottleneck for the export phase. These tasks are quite small but spend two thirds of their time importing the same packages.

Blocks: 1646939
No longer blocks: 1884317
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium!

It is costly to discover topobjdir when parent process knows it. So set
an environment variable inherited by child process and use it for
discovery when available

Attachment #9391122 - Attachment description: Bug 1884318 - Communicate topobdir to child process through env r=glandium → Bug 1884318 - Communicate topobjdir to child process through env r=glandium
Attachment #9391122 - Attachment description: Bug 1884318 - Communicate topobjdir to child process through env r=glandium → Bug 1884318 - Have preprocessor.py read topobjdir from CLI r=glandium
Attachment #9391122 - Attachment description: Bug 1884318 - Have preprocessor.py read topobjdir from CLI r=glandium → Bug 1884318 - Have preprocessor.py optionally read topobjdir from CLI r=glandium
Attachment #9391122 - Attachment description: Bug 1884318 - Have preprocessor.py optionally read topobjdir from CLI r=glandium → Bug 1884318 - Have preprocessor.py optionally read topobjdir from CLI r=glandium!
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium! → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium
See Also: → 1890540
Attachment #9391122 - Attachment is obsolete: true
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium!
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium! → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium!
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium! → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium
Attachment #9390106 - Attachment description: Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium → Bug 1884318 - Speedup preprocessor.py startup by restructuring imports r=glandium!
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: