1884320 - Speedup webidl custom enum type

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[[:sergesanspaille]]

Current implementation relies on __getattr__ overloading which is pretty slow

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1884320 - faster webildl.py: faster enum type r=ahochheiden

Current implementation relies on getattr which is relatively slow
(this method gets called upon failed attribute lookup) while we could
use a straight-forward implementation that keeps the same nice
properties.

Depends on D204006

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/092aaec7347a
faster webildl.py: faster enum type r=ahochheiden

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1884319 + Bug 1884321 + Bug 1884325 + Bug 1884327 for causing linting failures.

• backout: https://treeherder.mozilla.org/logviewer?job_id=450284020&repo=autoland&lineNumber=3912

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46071176ce0b
faster webildl.py: faster enum type r=ahochheiden

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/46071176ce0b