1884321 - webidl.py profiling shows half a second spent looking up the `filename()` method

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[[:sergesanspaille]]

In python, method calls are slower than attribute lookup, which can make a difference for repeatedly called methods that are actually attribute getter.

In [1]: class A:
   ...:     def __init__(self):
   ...:         self.var = 1
   ...: 

In [2]: class B:
   ...:     def __init__(self):
   ...:         self._var = 1
   ...:     def var(self):
   ...:         return self._var
   ...: 

In [3]: a = A()

In [4]: b = B()

In [5]: %timeit a.var
10.9 ns ± 0.457 ns per loop (mean ± std. dev. of 7 runs, 100,000,000 loops each)

In [6]: %timeit b.var()
28.7 ns ± 0.134 ns per loop (mean ± std. dev. of 7 runs, 10,000,000 loops each)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 1884321 - faster webildl.py: faster filename access r=ahochheiden

Depends on D204007

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bc46d60be63
faster webildl.py: faster filename access r=ahochheiden

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out with Bug 1884319 + Bug 1884320 + Bug 1884325 + Bug 1884327 for causing linting failures.

• backout: https://treeherder.mozilla.org/logviewer?job_id=450284020&repo=autoland&lineNumber=3912

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d60b35180991
faster webildl.py: faster filename access r=ahochheiden

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d60b35180991