1884631 - Consider removing WindowType::Sheet (native macOS sheet support)

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

See bug 1755330 for some of the troubles it historically causes.

I don't think we use them on macOS anymore, we use window-modal or tab-modal dialogs in firefox nowadays (e.g. the Ctrl+Q dialog is a "non-native" sheet of sorts).

Removing this would simplify the cross-platform widget code a little bit.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1884631 - Remove macOS native sheet support. r=#mac-reviewers!,#thunderbird-reviewers!

Firefox never uses this. TB could use the same approach Firefox uses,
but for now on macOS the sheets become regular modal dialogs, which is
the same as on Windows and Linux.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ed95f62c8ba
Remove macOS native sheet support. r=mac-reviewers,aleca,kaie,bradwerth

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Annotate some tests that assert now that we no longer use sheets for them, see Bug 1885891.
https://hg.mozilla.org/integration/autoland/rev/977e4367913e363604ceb804d6c2d8f2b74b4ebd

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2ed95f62c8ba
https://hg.mozilla.org/mozilla-central/rev/977e4367913e