1687758 - In spite of Reduce Motion and toolkit.cosmeticAnimations.enabled = false, painful animation in some dialogues in Thunderbird on Mac

Status: RESOLVED FIXED

(Thunderbird :: Disability Access, defect, P3)

Description

[MarjaE]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Tools > Message Filters > New

Actual results:

Hit with animation, migraine, nausea, couldn't set up filter.

"OK" (sic, and sic because sick) to try to get out

Hit with more animation, worse migraine, worse nausea.

Hit with "Alert: You Must Select a Target Folder."

Hit with more animation, worse migraine, worse nausea.

Quit Thunderbird to escape the animation.

Expected results:

Does Thunderbird need so much pain/animation? Especially for those of us who have set "Reduce Motion" in the system prefs?

Also toolkit.cosmeticAnimations.enabled false

xul.panel-animations.enabled false

Comment 1

[Wayne Mery (:wsmwk)]

We have several animation related issues reported. https://mzl.la/2NgPg2u

Comment 2

[MarjaE]

I can't find info about which window system Thunderbird uses:

https://developer.mozilla.org/en-US/Thunderbird

If the Mac version uses sheets for these dialogues, then defaults write -g NSWindowResizeTime -float [time in seconds for a 150 pixel change] is supposed to work for all apps which use sheets, and does not work for any app which uses sheets.

If the Mac version mimics sheets, then ... in my bemigrained opinion, that is not a good idea.

Comment 3

[MarjaE]

I found a Mac setting which helps:

defaults write -g NSAutomaticWindowAnimationsEnabled -bool false

I don't know if there are analoguous issues in Linux and Windows.

Comment 4

[Alessandro Castellani [:aleca]]

Are these dialog animations something we can control?
The message filter doesn't have any animation we specifically set that I'm aware of.
Shouldn't that toolkit pref interact with the OS for these cases?

Comment 5

[Richard Marti (:Paenglab)]

m-c has only three CSS rules to reduce the motion: https://searchfox.org/comm-central/search?q=%40media%20(prefers-reduced-motion%3A%20reduce)&case=false&regexp=false
And also some JS appearances: https://searchfox.org/comm-central/search?q=prefers-reduced-motion&path=&case=false&regexp=false

Comment 6

[Alessandro Castellani [:aleca]]

This is an issue with the fact that we're using macOS sheets to open the "new filter" dialog, and that dialog on macOS slides down from the top.
We're planning to remove the usage of sheets, we don't have a timeline yet but it's part of our objective to prevent these issues.

Comment 8

[Wayne Mery (:wsmwk)]

This and bug 225174 fixed by bug 1884631?

Comment 9

[Alessandro Castellani [:aleca]]

Yes, it should have since macOS sheets had that default slide down fade in motion and we don't use them anymore.

Comment 10

[Wayne Mery (:wsmwk)]

This will be available in 128.