1884632 - Handle heuristic for page navigations centrally in FormHandlerChild

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task)

Comment 1

[Janika Neuberger [:janika]]

Attachment: Bug 1884632 - P1. Handle heuristic for page navigations centrally in FormHandlerChild r=#credential-management-reviewers

Comment 2

[Janika Neuberger [:janika]]

Attachment: Bug 1884632 - P2. Rename browser_active_window_navigation.js r=#credential-management-reviewers

We extract the renaming of this test file to a separate patch, because P3 modifies and adds test cases and we want to keep the diff (to simplify review of P3).

Depends on D204927

Comment 3

[Janika Neuberger [:janika]]

Attachment: Bug 1884632 - P3. Update tests to align with the form submission on subtree navigation heuristic r=#credential-management-reviewers

Depends on D208133

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b53ac9b4590
P1. Handle heuristic for page navigations centrally in FormHandlerChild r=dimi,credential-management-reviewers,sgalich
https://hg.mozilla.org/integration/autoland/rev/082a2bed994a
P2. Rename browser_active_window_navigation.js r=credential-management-reviewers,dimi
https://hg.mozilla.org/integration/autoland/rev/f5a7db15ee4f
P3. Update tests to align with the form submission on subtree navigation heuristic r=credential-management-reviewers,dimi

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55c28baccbfd
Backed out 4 changesets (bug 1884632, bug 1895467) for causing gv-junit-fis failures CLOSED TREE

Comment 6

[Aron Cseh]

Backed out for causing gv-junit-fis failures

• Backout link
• Push with failures
• Failure Log

Comment 7

[Janika Neuberger [:janika]]

Hi Aron, thanks for pinging me!
My try push before landing didn't include the Android test suit that failed. I changed the events that FormAutofill listens for. And FormAutofill is consumed by GeckoView. I missed to reflect that event change in geckoview.js as well.
I updated the patch and ran the failing test suite (Android 7.0 x86-64 WebRender opt) on try:
https://treeherder.mozilla.org/jobs?repo=try&revision=ab2e8a59757a4134ab517f84c867979f95c12a05
It looks good now!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c6ccc1bcd07
P1. Handle heuristic for page navigations centrally in FormHandlerChild r=dimi,credential-management-reviewers,sgalich,geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/a6379151810d
P2. Rename browser_active_window_navigation.js r=credential-management-reviewers,dimi
https://hg.mozilla.org/integration/autoland/rev/234c9c49e671
P3. Update tests to align with the form submission on subtree navigation heuristic r=credential-management-reviewers,dimi

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/9c6ccc1bcd07
https://hg.mozilla.org/mozilla-central/rev/a6379151810d
https://hg.mozilla.org/mozilla-central/rev/234c9c49e671