1895467 - Undo the FormHandler integration with the FormHistoryChild

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task)

Description

[Janika Neuberger [:janika]]

FormHistory is currently not compatible with how the FormHandler is listening to form submissions so we are undoing the FormHandler integration in FormHistory from Bug 1881501.

Why?
The FormHandlerChild starts listening to form submission after it is created. But Bug 1884632 changes when the FormHandlerChild is created.
Now the FormHandlerChild is created when the FormAutofillChild or the LoginManagerChild register their interest in form submissions.
This means FormHistoryChild would need to register its interest as well, thus it needs to exist before the form submission occurs. And this causes a problem. Because in some cases, the FormHistoryChild doesn't exist before the form submission, so it cannot register its interest in time. Before introducing the FormHandler in Bug 1881501 the form submission was what created the FormHistoryChild and let it capture the submitted values.
This incompatibility could cause the FormHistoryChild to miss form submissions.

That's why we let the FormHistoryChild to directly listen for DOMFormBeforeSubmit again.

Comment 1

[Janika Neuberger [:janika]]

Attachment: Bug 1895467 - Undo the FormHandler integration with FormHistory r=#credential-management-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/26268f4f3f9d
Undo the FormHandler integration with FormHistory r=credential-management-reviewers,dimi

Comment 3

[Aron Cseh]

Backed out for causing gv-junit-fis failures

• Backout link
• Push with failures
• Failure Log

Comment 4

[Janika Neuberger [:janika]]

Replied in bug 1884632.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5bbdb42d93d
Undo the FormHandler integration with FormHistory r=credential-management-reviewers,dimi

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a5bbdb42d93d