1884744 - Build failure with --disable-updater: "ScheduledTask.cpp(16,10): fatal error: 'readstrings.h' file not found"

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/logviewer?job_id=450351405&repo=try&lineNumber=43228

INFO -  In file included from Unified_cpp_defaultagent0.cpp:74:
INFO -  /builds/worker/checkouts/gecko/toolkit/mozapps/defaultagent/ScheduledTask.cpp(16,10): fatal error: 'readstrings.h' file not found
INFO -     16 | #include "readstrings.h"
INFO -        |          ^~~~~~~~~~~~~~~
INFO -  1 error generated.

I'm guessing it's from this line being removed:
https://hg.mozilla.org/mozilla-central/diff/bbbbe75fe234c5737cfc95783c607ac94f95c22d/toolkit/mozapps/defaultagent/moz.build#l1.25

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1826375

:nrishel, since you are the author of the regressor, bug 1826375, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Nick Rishel [:nrishel]]

Weird this doesn't show up in a normal build, :RynaVM any intuition why? As far as I can tell this header doesn't appear to be used - ScheduledTask.cpp doesn't have any #if... macros and it appears to build without issue.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Per the bug title, ac_add_options --disable-updater is required.

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1884744 - Clean up unnecessary includes in default agent (some causing build failures). r=bytesized

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecb288dfc3a1
Clean up unnecessary includes in default agent (some causing build failures). r=bytesized

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ecb288dfc3a1