1826375 - Remove C++ Default Agent control flow fallback.

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, task, P3)

Description

[Nick Rishel [:nrishel]]

en-US used to have separate notification logic from all other locales in default-agent. This was switched off but the associated logic and config files were not trimmed down. We should clean these up at some point.

Comment 1

[Nick Rishel [:nrishel]]

Expanding the scope of this bug as we're minimizing changes to the existing C++ implementation to allow for fallback via Nimbus to the existing C++ control flow for the Default Agent. Once we're reasonably confident there are no issues we can remove the C++ implementation and Nimbus pref.

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1826375 - Part 1: Remove C++ `do-task` implementation for the Default Agent. r=mhughes

Comment 3

[Nick Rishel [:nrishel]]

Attachment: Bug 1826375 - Part 2: Remove WinToast. r=mhughes

WinToast had a single dependency in the Windows Default Agent which has since been migrated to Firefox's notification implementation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5f32253c79c
Part 1: Remove C++ `do-task` implementation for the Default Agent. r=mhughes,nalexander
https://hg.mozilla.org/integration/autoland/rev/7d6333da6d31
Part 2: Remove WinToast. r=mhughes,firefox-build-system-reviewers,sylvestre,nalexander

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for causing windows build bustages.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=bc8bdcfbcd9c788f4b8dbd7806f7d31d6e8e63ec&selectedTaskRun=c0vPhzLhSeOnkREv498Ung.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=449874388&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/e420cccb7ec93777f67029159c469f4c5063ad6f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bbbbe75fe234
Part 1: Remove C++ `do-task` implementation for the Default Agent. r=mhughes,nalexander,sylvestre
https://hg.mozilla.org/integration/autoland/rev/6b6632264e33
Part 2: Remove WinToast. r=mhughes,firefox-build-system-reviewers,sylvestre,nalexander

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/bbbbe75fe234
https://hg.mozilla.org/mozilla-central/rev/6b6632264e33