1884769 - Should Hide Translate Icon When in Reader View Mode

Status: VERIFIED FIXED

(Fenix :: Translations, defect, P2)

Description

[Olivia Hall [:olivia]]

It appears Reader View and Translations are not currently both supported at the same time based on testing with Desktop and receiving this error in Android, and with talking to other engineers.

We should hide the entry points into translations in the reader mode case. (Both toolbar and browser menu.) Desktop has browser menu greyed out and removes the toolbar entry point. Will confirm with UI/UX if we should follow an identical pattern.

Comment 1

[miralobontiu]

Attachment: screen-20240312-114623_Trim.mp4

So far, when a page is in reader mode, and I tap on the translation icon, the "There was a problem translating. Please try again." error is displayed.

Tested with a Google Pixel 6 (Android 14), on the latest Fenix Nightly 125.0a1.

Comment 2

[Olivia Hall [:olivia]]

Figma here for how to display while in reader mode.

Comment 3

[Iorga Gabriel]

Attachment: Bug 1884769 - Should Hide Translate Icon When in Reader View Mode.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db90809844d2
Should Hide Translate Icon When in Reader View Mode. r=android-reviewers,ohall

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing detekt linter failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/2126deb2ffbfba62097d461574758dbc0c204958

Push with failures

Failure log -> The function onState is too long (76). The maximum length is 75. [LongMethod]

L.E

Also these failures

file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:243:17: error: Cannot find a parameter with this name: onStateUpdated

file:///builds/worker/checkouts/gecko/mobile/android/android-components/components/browser/menu/src/test/java/mozilla/components/browser/menu/item/BrowserMenuImageTextCheckboxButtonTest.kt:128:72: error: Cannot access 'textColorResource'

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90ff939be339
Should Hide Translate Icon When in Reader View Mode. r=android-reviewers,ohall

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for causing failures on TranslationsBindingTest.kt

• backout: https://hg.mozilla.org/integration/autoland/rev/351595a679135f19b6f810bdc408aa3e2c58133b
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=Bic3apq2TvWr_UEB9m7-BA.0&revision=90ff939be339ccca886011f8c1551b97a07f55e6
• failure log: https://treeherder.mozilla.org/logviewer?job_id=454186120&repo=autoland&lineNumber=3194

[task 2024-04-10T15:11:20.525Z] > Task :app:compileFenixDebugUnitTestKotlin
[task 2024-04-10T15:11:41.725Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:243:17 Cannot find a parameter with this name: onStateUpdated
[task 2024-04-10T15:11:41.725Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:243:17: error: Cannot find a parameter with this name: onStateUpdated
[task 2024-04-10T15:11:41.725Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:243:34 Unresolved reference: onIconChanged
[task 2024-04-10T15:11:41.725Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:243:34: error: Unresolved reference: onIconChanged
[task 2024-04-10T15:11:41.725Z] e: file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:244:17 No value passed for parameter 'translationsIconStateUpdated'
[task 2024-04-10T15:11:41.725Z] file:///builds/worker/checkouts/gecko/mobile/android/fenix/app/src/test/java/org/mozilla/fenix/browser/TranslationsBindingTest.kt:244:17: error: No value passed for parameter 'translationsIconStateUpdated'
[task 2024-04-10T15:11:41.725Z] 
[task 2024-04-10T15:11:41.725Z] > Task :app:compileFenixDebugUnitTestKotlin FAILED
[task 2024-04-10T15:11:41.825Z] 
[task 2024-04-10T15:11:41.825Z] FAILURE: Build failed with an exception.
[task 2024-04-10T15:11:41.825Z] 
[task 2024-04-10T15:11:41.825Z] * What went wrong:
[task 2024-04-10T15:11:41.825Z] Execution failed for task ':app:compileFenixDebugUnitTestKotlin'.
[task 2024-04-10T15:11:41.825Z] > A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
[task 2024-04-10T15:11:41.825Z]    > Compilation error. See log for more details
[task 2024-04-10T15:11:41.825Z] 

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d1a0dcb7da6
Should Hide Translate Icon When in Reader View Mode. r=android-reviewers,ohall,gl

Comment 9

[Iorga Gabriel]

I fixed the unittests.

Comment 10

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/9d1a0dcb7da6

Comment 11

[miralobontiu]

Attachment: 1884769_Trim.mp4

Verified as implemented on the latest Fenix Nightly 126.0a1 from 4/12, with the following devices:

• Xiaomi mi8 Lite (Android 10),
• Google Pixel 6 (Android 14), and
• Lenovo M10 tablet (Android 10).

The page, once in reader mode, is not displaying the translation icon in the toolbar.
However, the transition is not smooth, so I filed Bug 1891192 for this visual glitch.