1884792 - Remove chrome-only :-moz-lwtheme pseudo-class

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

We don't have that many usages of it (link), and main idea is that it doesn't change frequently, so it'd be cheaper.

It'd also potentially allow us to expose more information about it to pages that aren't themed themselves.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: WIP: Bug 1884792 - Make -moz-lwtheme a media query.

I had this pretty much written, but then again, thinking more about it,
why not just kill it?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1884792 - Remove chrome-only :-moz-lwtheme pseudo-class. r=#theme!

Behavior is effectively :root[lwtheme="true"]. Use the attribute
selector instead.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

FYI, I think we should wait until after the soft-freeze to land this. TB has a few more than Firefox, but they can be removed the same way.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

comment 3 was meant to ni? y'all

Comment 5

[Richard Marti (:Paenglab)]

Landing after the soft-freeze would be great. Then I can look into it during the next weekend.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Cool, will do.

Comment 7

[Magnus Melin [:mkmelin]]

Thanks, filed bug 1884997.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc58cf6254d6
Remove chrome-only :-moz-lwtheme pseudo-class. r=desktop-theme-reviewers,dao

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a95f77e09675
Push a typo fix that had been lost during rebase.

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/bc58cf6254d6
https://hg.mozilla.org/mozilla-central/rev/a95f77e09675