1901298 - Tab has no focus ring when a LWT is installed

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Mark Striemer [:mstriemer]]

With a LWT installed there is no focus ring shown when a tab is focused.

STR

1. Install a LWT (Light/Dark/Alpenglow all reproduce)
2. Press F6, Shift+Tab to the New Tab button
3. Press Shift+Tab again
4. Press Left/Right to change tabs

Expected results: The tab has a focus ring
Actual results: No focus ring is shown

Comment 1

[Dão Gottwald [:dao]]

I believe this is a regression. Would be helpful to know when this broke.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cmkm, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Giorgia Nichita, Release Desktop QA]

I ran mozregression and reached the following pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2ed95f62c8ba239daadc33b7f909253ca318d2fd&tochange=bc58cf6254d68d3c8a59b3eb6d703f63070a74a4

It seems that Bug 1884792 is the regressor.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1884792, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1901298 - Clean-up tab outlines. r=dao,mstriemer

Make it a bit easier to follow / harder to mess up the specificity.

The issue is that the lwtheme rule was more specific than the keyboard
background since the regressing bug.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8bd09dfd2f83
Clean-up tab outlines. r=dao,desktop-theme-reviewers,tabbrowser-reviewers

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8bd09dfd2f83

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1901298 - Clean-up tab outlines.

Make it a bit easier to follow / harder to mess up the specificity.

The issue is that the lwtheme rule was more specific than the keyboard
background since the regressing bug.

Original Revision: https://phabricator.services.mozilla.com/D215381

Comment 10

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Keyboard focus indication with a theme is broken.
• Code covered by automated testing: no
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: Relatively straight-forward patch
• String changes made/needed: none
• Is Android affected?: no

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9410810 [details]
Bug 1901298 - Clean-up tab outlines.

128 is in RC now, moving the request accordingly.

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/725fcc32237b

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr128/rev/725fcc32237b

Comment 14

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox Nightly 129.0a1 (2024-07-03), using Windows 10, Ubuntu 22.04 and macOS 11.
We will verify this on the official 128.0-build 2 and 128.0esr build 2 when available.

Comment 15

[Giorgia Nichita, Release Desktop QA]

Verified as fixed on Firefox 128.0-build2 RC (build ID 20240704121409) and on Firefox 128esr-build2 (build ID 20240703235920) across the following platforms: Windows 10, Ubuntu 22.04 and macOS 11.