1885134 - Firefox View selected and focused category is displayed with extra border frame

Status: VERIFIED FIXED

(Firefox :: Firefox View, defect, P3)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 125.0a1.png

Affected versions

• Nightly 125.0a1

Affected platforms

• Windows 10 x64
• Untested platforms: Ubuntu, Mac

Steps to reproduce

1. Go to Firefox View page
2. Using Tab key select the Firefox View categories: Recent Browsing, Open Tabs
3. Observe the Firefox View selected category

Expected result

• Firefox View Tab key selected category should be displayed properly

Actual result

• Firefox View selected and focused category is displayed with extra border frame

Regression range

• First bad: 2024-02-21
• Last good: 2024-02-22
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bf0897ec442e625c185407cc615a6adc0e40fa75&tochange=558067032002ffc8a775205a29adbe2dd686df28
• Potential regressor: Bug 1850591

Additional notes

• See the attached screenshots for more information

Comment 1

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 124.0.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1850591

:kcochrane, since you are the author of the regressor, bug 1850591, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1885134 - Fix outline offset and other styles of moz-page-nav-button to match spec r=mstriemer

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/195480a1eaa5
Fix outline offset and other styles of moz-page-nav-button to match spec r=mstriemer,reusable-components-reviewers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1850591

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/195480a1eaa5

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:kcochrane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Attachment: thick border on the left side

I was able to replicate the issue on an affected Firefox Nightly 125.0a1 build, from 2024-02-21, under macOS 12.6.6 while following the steps described in Comment 0.
Verified on Firefox RC 126.0, build ID 20240506203248, using macOS 12.6.6, Windows 11 and Ubuntu 22.04 and now Firefox View selected and focused category is displayed with a thick border framing the left side.
@kcochrane, is this the intended? Please see the attached screenshot. Thanks in advance!

Comment 9

[Kelly Cochrane [:kcochrane]]

Hi, :bhidecuti! Yes, that is the expected behavior. Here's a link to the spec in Figma where you can see the Selected + Focused nav menu buttons are thicker on the left side to indicate the focused button is also the currently selected one. Thanks for double checking!

Comment 10

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

Thank you for the clarification!
Based on Comment 8 I am marking this verified as fixed.