1850591 - Convert Firefox View's domain-specific Category Navigation to a global component

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Jules Simplicio [:jules]]

Attachment: nav and heading relationship today.png

The Information Management team working on Firefox View has implemented a sidebar navigation component under their domain-specific space in Storybook. The design, which is a pattern that occurs in a few about pages (e.g. preferences, addons), went through rounds of accessibility, engineering, and design reviews, and has been improved. UX (Eric Pang) requested to get this navigation component implemented in the other about: pages that rely on the same pattern.

We should graduate Firefox View's Category Navigation domain-specific component to the global level so that we can standardize our about: pages navigation pattern across Firefox.

I am requesting info from Eric since this change would involve moving about: page titles above the navigation instead of above the body. Let me know if that's cool and intended. Attaching some before and after pics of what would happen.

Comment 1

[Jules Simplicio [:jules]]

Attachment: nav and heading relationship with new component.png

Comment 2

[Jules Simplicio [:jules]]

Attachment: nav with title.png

Followed up with Eric. I had attached an incorrect design of the future change - this would actually be what would happen to the nav in about: pages if we kept feature title at the top of the nav. We discussed that this is a welcomed change, as it makes it clearer what feature the user is under.

Here's a link to the latest design's components in Figma provided by Eric.

Comment 3

[Jules Simplicio [:jules]]

Attachment: nav with title (preferences instead of settings).png

Comment 4

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component

Comment 5

[Hanna Jones [:hjones]]

Attachment: WIP: Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=mstriemer

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e97e98c4b7c2
Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod

Comment 7

[Atila Butkovits]

Backed out for causing failures at browser_1856572_ensure_Fluent_works_in_customizeMode.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/4db18f6ce06e4e3f1d7197c4c3e9b52cced593fa

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e97e98c4b7c2fe4ecd0a102fb08fdfb37deee78f&selectedTaskRun=OYhccWd6RL2c35nQOq9gkw.0

Failure log:
https://treeherder.mozilla.org/logviewer?job_id=446683828&repo=autoland&lineNumber=6508
https://treeherder.mozilla.org/logviewer?job_id=446683844&repo=autoland&lineNumber=8525

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f19610ecbade
Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod

Comment 9

[Noemi Erli[:noemi_erli]]

Backed out changeset f19610ecbade (Bug 1850591) for causing failures in browser_opentabs_tab_indicators.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=dFeg3PuBSKibtMCk3GXwPQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f19610ecbade6731196be6f4ae28200fccfe0975

Log: https://treeherder.mozilla.org/logviewer?job_id=446752763&repo=autoland&lineNumber=4230
TV: https://treeherder.mozilla.org/logviewer?job_id=446752760&repo=autoland&lineNumber=13411

Backout: https://hg.mozilla.org/integration/autoland/rev/0bc92f4e8733dbc75bce79c3fef94c162bbbd06e

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f77525a9adea
Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f77525a9adea